fix: Restore config changes that broke standalone mode - #6301
Merged
Conversation
9 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #6301 +/- ##
=========================================
- Coverage 79.8% 79.8% -0.0%
=========================================
Files 839 839
Lines 65528 65530 +2
Branches 7273 7292 +19
=========================================
- Hits 52324 52303 -21
- Misses 13204 13227 +23
... and 4 files with indirect coverage changes 🚀 New features to boost your workflow:
|
a1q123456
approved these changes
Feb 2, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a critical bug in standalone mode that was introduced by PR #6098. The bug prevented xrpld from starting in standalone mode when the database directory didn't exist, causing crashes with "unable to open database file" or filesystem errors.
Changes:
- Restored logic to clear the data directory path when running in standalone mode without an explicit database_path configuration
- Changed directory creation condition from checking if NOT in standalone mode to checking if the data directory path is not empty
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
legleux
approved these changes
Feb 2, 2026
legleux
left a comment
legleux
left a comment
Contributor
There was a problem hiding this comment.
Seems to resolve the issue of the directory not being created at startup
bthomee
enabled auto-merge (squash)
February 3, 2026 00:47
bthomee
added a commit
that referenced
this pull request
Feb 3, 2026
When support was added for `xrpld.cfg` in addition to `rippled.cfg` in #6098, as part of an effort to rename occurrences of ripple(d) to xrpl(d), the clearing and creation of the data directory were modified for what, at the time, seemed to result in an equivalent code flow. This has turned out to not be true, which is why this change restores two modifications to `Config.cpp` that currently break running the binary in standalone mode.
beartec-jpg
pushed a commit
to beartec-jpg/FalconLedger
that referenced
this pull request
Jun 1, 2026
When support was added for `xrpld.cfg` in addition to `rippled.cfg` in XRPLF#6098, as part of an effort to rename occurrences of ripple(d) to xrpl(d), the clearing and creation of the data directory were modified for what, at the time, seemed to result in an equivalent code flow. This has turned out to not be true, which is why this change restores two modifications to `Config.cpp` that currently break running the binary in standalone mode.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
This change restores two modifications to
Config.cppthat currently break running the binary in standalone mode.Fixes #6299
Context of Change
When support was added for
xrpld.cfgin addition torippled.cfgin #6098, as part of an effort to rename occurrences of ripple(d) to xrpl(d), the clearing and creation of the data directory were modified for what, at the time, seemed to result in an equivalent code flow. This has turned out to not be true, which is why this change restores specific modifications.Type of Change
.gitignore, formatting, dropping support for older tooling)