style: Set ColumnLimit to 120 in clang-format - #6288
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the clang-format configuration to increase the ColumnLimit from 80 to 120 characters, and applies this formatting change across the entire codebase. This allows longer lines of code to remain on a single line rather than being broken across multiple lines.
Changes:
- Updated
.clang-formatto setColumnLimit: 120 - Reformatted all affected source and header files to comply with the new 120-character line limit
Reviewed changes
Copilot reviewed 245 out of 1016 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| .clang-format | Updated ColumnLimit from 80 to 120 |
| src/libxrpl/ledger/*.cpp | Consolidated multi-line function signatures and statements to single lines where appropriate |
| src/libxrpl/json/*.cpp | Reformatted to fit within 120 character limit |
| src/libxrpl/crypto/*.cpp | Consolidated function calls to single lines |
| src/libxrpl/core/detail/*.cpp | Reformatted constructor initializer lists and function signatures |
| src/libxrpl/beast/**/*.cpp | Applied 120 character formatting throughout beast library sources |
| src/libxrpl/basics/*.cpp | Consolidated multi-line expressions and function calls |
| include/xrpl/**/*.h | Reformatted header files to comply with new line limit |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
bthomee
approved these changes
Jan 28, 2026
bthomee
left a comment
bthomee
left a comment
Collaborator
There was a problem hiding this comment.
Once merged we probably should add the commit hash to .git-blame-ignore-revs.
legleux
self-requested a review
January 28, 2026 17:24
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #6288 +/- ##
=========================================
+ Coverage 79.4% 79.9% +0.5%
=========================================
Files 839 839
Lines 71625 65528 -6097
Branches 8236 7268 -968
=========================================
- Hits 56854 52331 -4523
+ Misses 14771 13197 -1574
... and 367 files with indirect coverage changes 🚀 New features to boost your workflow:
|
legleux
approved these changes
Jan 28, 2026
mathbunnyru
added
the
Ready to merge
beartec-jpg
pushed a commit
to beartec-jpg/FalconLedger
that referenced
this pull request
Jun 1, 2026
This change updates the ColumnLimit from 80 to 120, and applies clang-format to reformat the code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
This only changes 80 -> 120 for ColumnLimit and reruns clang-format, no manual changes were done.
Context of Change
Type of Change
.gitignore, formatting, dropping support for older tooling)API Impact
libxrplchange (any change that may affectlibxrplor dependents oflibxrpl)