refactor: clean up uses of std::source_location - #6272
Merged
Conversation
mvadari
added
the
Trivial
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes obsolete Clang version checks for std::source_location support. Since the minimum supported Clang version is now 16, the conditional includes for std::experimental::source_location (used for Clang < 15) are no longer necessary.
Changes:
- Removed conditional preprocessor directives checking for Clang < 15
- Replaced
using source_locationdeclarations with fully qualifiedstd::source_locationusage - Cleaned up includes by removing experimental source_location support
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/test/rpc/LedgerEntry_test.cpp | Removed Clang < 15 version checks and updated all source_location references to std::source_location |
| src/test/jtx/TestHelpers.h | Removed Clang < 15 version checks, updated source_location references to std::source_location, and reordered includes |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #6272 +/- ##
=========================================
- Coverage 79.4% 79.4% -0.0%
=========================================
Files 839 839
Lines 71619 71619
Branches 8231 8235 +4
=========================================
- Hits 56855 56850 -5
- Misses 14764 14769 +5 see 3 files with indirect coverage changes 🚀 New features to boost your workflow:
|
bthomee
approved these changes
Jan 23, 2026
beartec-jpg
pushed a commit
to beartec-jpg/FalconLedger
that referenced
this pull request
Jun 1, 2026
Since the minimum Clang version we support is 16, the checks for version < 15 are no longer necessary. This change therefore removes the macros checking if the clang version is < 15 and simplifies uses of `std::source_location`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
This PR simplifies uses of
std::source_locationremove the macros checking if the clang version is < 15.No source code changes.
Context of Change
The minimum Clang version supported is 16, so the checks for version < 15 are no longer necessary.
Type of Change
.gitignore, formatting, dropping support for older tooling)API Impact
N/A
Test Plan
CI still compiles and passes on all versions.