Sponsored Content
Skip to content

ci: Explicitly set version when exporting the Conan recipe - #6264

Merged
bthomee merged 3 commits into
developfrom
bthomee/version
Jan 22, 2026
Merged

ci: Explicitly set version when exporting the Conan recipe#6264
bthomee merged 3 commits into
developfrom
bthomee/version

Conversation

@bthomee

@bthomee bthomee commented Jan 22, 2026

Copy link
Copy Markdown
Collaborator

High Level Overview of Change

This change explicitly sets the version when exporting the Conan recipe, and optimizes the steps in the upload workflow.

Context of Change

By default the Conan recipe extracts the version from BuildInfo.cpp, but in some of the cases we want to upload a recipe with a suffix derived from the commit hash. This currently then results in the uploading to fail, since there is a version mismatch.

Here we explicitly set the version, and then simplify the steps in the upload workflow since we now need the recipe name (embedded within the conanfile.py but also needed when uploading), the recipe version, and the recipe ref (name/version).

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Performance (increase or change in throughput and/or latency)
  • Tests (you added tests for code that already exists, or your new feature included in this PR)
  • Documentation update
  • Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
  • Release

@bthomee
bthomee requested a review from mathbunnyru January 22, 2026 17:38
@bthomee bthomee added the Trivial Simple change with minimal effect, or already tested. Only needs one approval. label Jan 22, 2026
Comment thread .github/workflows/reusable-upload-recipe.yml Outdated
@codecov

codecov Bot commented Jan 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.4%. Comparing base (4e3f953) to head (a0aaeb0).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #6264   +/-   ##
=======================================
  Coverage     79.4%   79.4%           
=======================================
  Files          839     839           
  Lines        71619   71619           
  Branches      8237    8233    -4     
=======================================
+ Hits         56848   56856    +8     
+ Misses       14771   14763    -8     

see 1 file with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bthomee
bthomee enabled auto-merge (squash) January 22, 2026 18:53
@bthomee
bthomee merged commit c57ffdb into develop Jan 22, 2026
3 checks passed
@bthomee
bthomee deleted the bthomee/version branch January 22, 2026 19:06
@mvadari mvadari added this to the 3.2.0 milestone May 20, 2026
beartec-jpg pushed a commit to beartec-jpg/FalconLedger that referenced this pull request Jun 1, 2026
By default the Conan recipe extracts the version from `BuildInfo.cpp`, but in some of the cases we want to upload a recipe with a suffix derived from the commit hash. This currently then results in the uploading to fail, since there is a version mismatch.

Here we explicitly set the version, and then simplify the steps in the upload workflow since we now need the recipe name (embedded within the conanfile.py but also needed when uploading), the recipe version, and the recipe ref (name/version).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Trivial Simple change with minimal effect, or already tested. Only needs one approval.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants