Sponsored Content
Skip to content

ci: Use plus instead of hyphen for Conan recipe version suffix - #6261

Merged
bthomee merged 2 commits into
developfrom
bthomee/plus
Jan 22, 2026
Merged

ci: Use plus instead of hyphen for Conan recipe version suffix#6261
bthomee merged 2 commits into
developfrom
bthomee/plus

Conversation

@bthomee

@bthomee bthomee commented Jan 22, 2026

Copy link
Copy Markdown
Collaborator

High Level Overview of Change

This change uses a + to separate a version suffix (commit hash) instead of a -.

Context of Change

Conan recipes use semantic versioning, and since our version already creates a hyphen the second hyphen causes Conan to ignore it. The plus sign is a valid separator we can use instead.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Performance (increase or change in throughput and/or latency)
  • Tests (you added tests for code that already exists, or your new feature included in this PR)
  • Documentation update
  • Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
  • Release

@bthomee bthomee added the Trivial Simple change with minimal effect, or already tested. Only needs one approval. label Jan 22, 2026
@bthomee
bthomee enabled auto-merge (squash) January 22, 2026 16:17
@codecov

codecov Bot commented Jan 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.4%. Comparing base (a4f8aa6) to head (779eb7b).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #6261   +/-   ##
=======================================
  Coverage     79.4%   79.4%           
=======================================
  Files          839     839           
  Lines        71619   71619           
  Branches      8234    8232    -2     
=======================================
+ Hits         56852   56853    +1     
+ Misses       14767   14766    -1     

see 2 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bthomee
bthomee merged commit 4e3f953 into develop Jan 22, 2026
3 checks passed
@bthomee
bthomee deleted the bthomee/plus branch January 22, 2026 16:42
@mvadari mvadari added this to the 3.2.0 milestone May 20, 2026
beartec-jpg pushed a commit to beartec-jpg/FalconLedger that referenced this pull request Jun 1, 2026
…#6261)

Conan recipes use semantic versioning, and since our version already contains a hyphen the second hyphen causes Conan to ignore it. The plus sign is a valid separator we can use instead, so this change uses a `+` to separate a version suffix (commit hash) instead of a `-`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Trivial Simple change with minimal effect, or already tested. Only needs one approval.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants