Detect uninitialized variables in CMake files. - #6247
Merged
bthomee merged 6 commits intoJan 22, 2026
Conversation
mathbunnyru
requested changes
Jan 21, 2026
mathbunnyru
left a comment
mathbunnyru
left a comment
Contributor
There was a problem hiding this comment.
@pratikmankawde could we please not introduce style changes to this PR?
It makes it less focused and more difficult to read
mathbunnyru
requested changes
Jan 21, 2026
Contributor
Author
Yes, I will revert the style changes. |
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com>
pratikmankawde
force-pushed
the
pratik/Detect-uninitialized-variables-in-CMake-files
branch
from
January 21, 2026 14:02
f308b01 to
d10ddb7
Compare
bthomee
reviewed
Jan 21, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #6247 +/- ##
=======================================
Coverage 79.4% 79.4%
=======================================
Files 839 839
Lines 71619 71619
Branches 8238 8237 -1
=======================================
+ Hits 56846 56848 +2
+ Misses 14773 14771 -2 see 2 files with indirect coverage changes 🚀 New features to boost your workflow:
|
bthomee
reviewed
Jan 21, 2026
Comment on lines
+36
to
39
| $<$<BOOL:${is_xcode}>: | ||
| --system-header-prefix="google/protobuf" | ||
| -Wno-deprecated-dynamic-exception-spec | ||
| > |
Collaborator
There was a problem hiding this comment.
Can we confirm this is still needed? Does anyone use Xcode to develop?
Contributor
Author
There was a problem hiding this comment.
Who can confirm this?
Co-authored-by: Bart <bthomee@users.noreply.github.com>
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com>
…f github.com:XRPLF/rippled into pratik/Detect-uninitialized-variables-in-CMake-files
mathbunnyru
approved these changes
Jan 21, 2026
bthomee
approved these changes
Jan 22, 2026
bthomee
deleted the
pratik/Detect-uninitialized-variables-in-CMake-files
branch
January 22, 2026 16:16
beartec-jpg
pushed a commit
to beartec-jpg/FalconLedger
that referenced
this pull request
Jun 1, 2026
There were a few uninitialized variables in CMake files. This change will make sure we always check if a variable has been initialized before using them, or in come cases initialize them by default. This change will raise an error on CI if a developer introduced an uninitialized variable in CMake files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Detects and raises an error for un-initialized CMake variables.
Context of Change
We had a-few uninitialized variables in CMake files. This change will make sure we always check if a variable has been initiazed before using them. Or in come cases default initialize them. This change will raise an error on CI if a dev. introduced an un-initialized variable in CMake files.
Type of Change
.gitignore, formatting, dropping support for older tooling)API Impact
None
Test Plan
Tested locally.