ci: Upload Conan recipe for merges into develop and commits to release - #6235
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #6235 +/- ##
=======================================
Coverage 79.4% 79.4%
=======================================
Files 839 839
Lines 71634 71634
Branches 8238 8237 -1
=======================================
+ Hits 56858 56859 +1
+ Misses 14776 14775 -1 see 3 files with indirect coverage changes 🚀 New features to boost your workflow:
|
mathbunnyru
requested changes
Jan 19, 2026
mathbunnyru
requested changes
Jan 20, 2026
mathbunnyru
approved these changes
Jan 20, 2026
kuznetsss
approved these changes
Jan 21, 2026
kuznetsss
left a comment
kuznetsss
left a comment
Contributor
There was a problem hiding this comment.
LGTM, just one question
mathbunnyru
approved these changes
Jan 21, 2026
mathbunnyru
reviewed
Jan 21, 2026
mathbunnyru
left a comment
mathbunnyru
left a comment
Contributor
There was a problem hiding this comment.
Wrote a comment above, please take a look
mathbunnyru
approved these changes
Jan 21, 2026
bthomee
added a commit
that referenced
this pull request
Jan 22, 2026
During several iterations of development of #6235, the commit hash was supposed to be moved into the `run:` statement, but it slipped through the cracks and did not get added. This change adds the commit hash as suffix to the Conan recipe version.
beartec-jpg
pushed a commit
to beartec-jpg/FalconLedger
that referenced
this pull request
Jun 1, 2026
XRPLF#6235) This change uploads the `libxrpl` library as a Conan recipe to our remote when (i) merging into the `develop` branch, (ii) committing to a PR that targets a `release*` branch, and (iii) a versioned tag is applied. Clio is only notified in the second case. The user and channel are no longer used when uploading the recipe. Specific changes are: * A `generate-version` action is added, which extracts the build version from `BuildInfo.cpp` and appends the short 7-character commit hash to it for merges into the `develop` branch and for commits to a PR that targets a `release*` branch. When a tag is applied, however, the tag itself is used as the version. This functionality has been turned into a separate action as we will use the same versioning logic for creating .rpm and .deb packages, as well as Docker images. * An `upload-recipe` action is added, which calls the `generate-version` action and further handles the uploading of the recipe to Conan. * This action is called by both the `on-pr` and `on-trigger` workflows, and a new `on-tag` workflow. The reason for this change is that we have downstream uses for the `libxrpl` library, but currently only upload the recipe to check for compatibility with Clio when making commits to a PR that targets the release branch.
beartec-jpg
pushed a commit
to beartec-jpg/FalconLedger
that referenced
this pull request
Jun 1, 2026
During several iterations of development of XRPLF#6235, the commit hash was supposed to be moved into the `run:` statement, but it slipped through the cracks and did not get added. This change adds the commit hash as suffix to the Conan recipe version.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
This change uploads the
libxrpllibrary as a Conan recipe to our remote when (i) merging into thedevelopbranch, (ii) committing to a PR that targets arelease*branch, and (iii) a versioned tag is applied. Clio is only notified in the second case. The user and channel are no longer used when uploading the recipe.Context of Change
We have downstream uses for the
libxrpllibrary, but currently only upload the recipe to check for compatibility with Clio when making commits to a PR that targets the release branch.generate-versionaction is added, which extracts the build version fromBuildInfo.cppand appends the short 7-character commit hash to it for merges into thedevelopbranch and for commits to a PR that targets arelease*branch. When a tag is applied, however, the tag itself is used as the version. This functionality has been turned into a separate action as we will use the same versioning logic for creating .rpm and .deb packages, as well as Docker images.upload-recipeaction is added, which calls thegenerate-versionaction and further handles the uploading of the recipe to Conan.on-prandon-triggerworkflows, and a newon-tagworkflow.Type of Change
.gitignore, formatting, dropping support for older tooling)