fix: Gateway balance with MPT - #6143
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #6143 +/- ##
=========================================
- Coverage 79.8% 79.8% -0.0%
=========================================
Files 858 858
Lines 67764 67766 +2
Branches 7575 7555 -20
=========================================
- Hits 54084 54076 -8
- Misses 13680 13690 +10
🚀 New features to boost your workflow:
|
amp08052526-wq
approved these changes
Dec 12, 2025
godexsoft
reviewed
Feb 12, 2026
godexsoft
left a comment
Contributor
There was a problem hiding this comment.
I'm worried that this is not a fix but just ignoring the problem. If it's the correct way then it is fine.
Contributor
|
@godexsoft this is the correct fix. Gateway balance is an RPC that's only applicable to IOUs, so we need to skip whenever we see a MPT type. |
shawnxie999
approved these changes
Mar 3, 2026
bthomee
enabled auto-merge (squash)
March 4, 2026 15:20
bthomee
pushed a commit
that referenced
this pull request
Apr 7, 2026
When `gateway_balances` gets called on an account that is involved in the `EscrowCreate` transaction (with MPT being escrowed), the method returns internal error. This change fixes this case by excluding the MPT type when totaling escrow amount.
ximinez
pushed a commit
that referenced
this pull request
Apr 10, 2026
When `gateway_balances` gets called on an account that is involved in the `EscrowCreate` transaction (with MPT being escrowed), the method returns internal error. This change fixes this case by excluding the MPT type when totaling escrow amount.
ximinez
pushed a commit
that referenced
this pull request
Apr 22, 2026
When `gateway_balances` gets called on an account that is involved in the `EscrowCreate` transaction (with MPT being escrowed), the method returns internal error. This change fixes this case by excluding the MPT type when totaling escrow amount.
beartec-jpg
pushed a commit
to beartec-jpg/FalconLedger
that referenced
this pull request
Jun 1, 2026
When `gateway_balances` gets called on an account that is involved in the `EscrowCreate` transaction (with MPT being escrowed), the method returns internal error. This change fixes this case by excluding the MPT type when totaling escrow amount.
32 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context of Change
When
gateway_balancesgets called on an account that is involved in EscrowCreate transaction (with MPT being escrowed), the method returns internal error. This PR fixes this case by excluding the MPT type when totaling escrow amount.Type of Change
.gitignore, formatting, dropping support for older tooling)API Impact
libxrplchange (any change that may affectlibxrplor dependents oflibxrpl)