refactor: Replaces ed25519-donna source by Conan package - #6088
Merged
Conversation
mathbunnyru
approved these changes
Nov 27, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #6088 +/- ##
=========================================
- Coverage 78.6% 78.6% -0.0%
=========================================
Files 818 818
Lines 68938 68938
Branches 8242 8241 -1
=========================================
- Hits 54178 54162 -16
- Misses 14760 14776 +16 🚀 New features to boost your workflow:
|
beartec-jpg
pushed a commit
to beartec-jpg/FalconLedger
that referenced
this pull request
Jun 1, 2026
This change substitutes the `ed25519-donna` source code copy by the Conan recipe added in XRPLF/conan-center-index#23.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
This change substitutes the
ed25519-donnasource code copy by the Conan recipe added in XRPLF/conan-center-index#23.Context of Change
There was no Conan package for
ed25519-donna, so its source code was added to theexternal/directory and compiled as part ofrippled. As we recently created a package for it in our own Conan Center Index fork, we can now switch to using that package.Type of Change
.gitignore, formatting, dropping support for older tooling)