Sponsored Content
Skip to content

style: Add black pre-commit hook - #6086

Merged
bthomee merged 1 commit into
XRPLF:developfrom
mathbunnyru:black_pc
Nov 26, 2025
Merged

style: Add black pre-commit hook#6086
bthomee merged 1 commit into
XRPLF:developfrom
mathbunnyru:black_pc

Conversation

@mathbunnyru

@mathbunnyru mathbunnyru commented Nov 26, 2025

Copy link
Copy Markdown
Contributor

High Level Overview of Change

We format code with black in Clio, it makes sense to have it in rippled as well, it will reduce significantly codestyle problems.

Clio PR: XRPLF/clio#2811

Context of Change

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Performance (increase or change in throughput and/or latency)
  • Tests (you added tests for code that already exists, or your new feature included in this PR)
  • Documentation update
  • Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
  • Release

API Impact

  • Public API: New feature (new methods and/or new fields)
  • Public API: Breaking change (in general, breaking changes should only impact the next api_version)
  • libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
  • Peer protocol change (must be backward compatible or bump the peer protocol version)

@mathbunnyru
mathbunnyru requested a review from bthomee November 26, 2025 18:41
@mathbunnyru mathbunnyru added Trivial Simple change with minimal effect, or already tested. Only needs one approval. Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. labels Nov 26, 2025
@bthomee
bthomee enabled auto-merge (squash) November 26, 2025 18:58
@bthomee
bthomee merged commit f399749 into XRPLF:develop Nov 26, 2025
1 check passed
@codecov

codecov Bot commented Nov 26, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.6%. Comparing base (4e25dc9) to head (728148b).
⚠️ Report is 2 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop   #6086     +/-   ##
=========================================
- Coverage     78.6%   78.6%   -0.0%     
=========================================
  Files          818     818             
  Lines        68938   68938             
  Branches      8231    8237      +6     
=========================================
- Hits         54176   54166     -10     
- Misses       14762   14772     +10     

see 2 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mvadari mvadari added this to the 3.2.0 milestone May 20, 2026
beartec-jpg pushed a commit to beartec-jpg/FalconLedger that referenced this pull request Jun 1, 2026
This change adds Black as a pre-commit hook to format Python files.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. Trivial Simple change with minimal effect, or already tested. Only needs one approval.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants