Refactor: Update PermissionedDomainDelete to use keylet for sle access - #6063
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #6063 +/- ##
=======================================
Coverage 79.8% 79.8%
=======================================
Files 858 858
Lines 67764 67764
Branches 7555 7548 -7
=======================================
+ Hits 54074 54087 +13
+ Misses 13690 13677 -13
... and 7 files with indirect coverage changes 🚀 New features to boost your workflow:
|
| auto const ownerSle = view().peek(keylet::account(account_)); | ||
| auto const owner = (*slePd)[sfOwner]; | ||
| auto const ownerSle = view().peek(keylet::account(owner)); |
There was a problem hiding this comment.
Why the change here? They are already checked that they are the same in preclaim
There was a problem hiding this comment.
because it is more intuitive.
Future readers of this code will no longer need to check preclaim.
There was a problem hiding this comment.
Probably better to split it into another PR?
There was a problem hiding this comment.
@tequdev, could you please remove this 2 lines change as it looks not necessary here?
|
@tequdev can you update the PR description? |
mvadari
added
the
Trivial
|
@tequdev is this PR ready to go? |
yes |
mvadari
added
the
Ready to merge
6 participants
High Level Overview of Change
Refactor to explicitly use
keylet::permissionedDomaininPermissionedDomainDeleteprocessing.Context of Change
Refactor to explicitly use
keylet::permissionedDomaininPermissionedDomainDeleteprocessing.Type of Change