Sponsored Content
Skip to content

Retire Flow and FlowSortStrands - #6054

Merged
bthomee merged 12 commits into
developfrom
a1q123456/retire-Flow
Nov 25, 2025
Merged

Retire Flow and FlowSortStrands#6054
bthomee merged 12 commits into
developfrom
a1q123456/retire-Flow

Conversation

@a1q123456

@a1q123456 a1q123456 commented Nov 19, 2025

Copy link
Copy Markdown
Contributor

High Level Overview of Change

Context of Change

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Performance (increase or change in throughput and/or latency)
  • Tests (you added tests for code that already exists, or your new feature included in this PR)
  • Documentation update
  • Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
  • Release

API Impact

  • Public API: New feature (new methods and/or new fields)
  • Public API: Breaking change (in general, breaking changes should only impact the next api_version)
  • libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
  • Peer protocol change (must be backward compatible or bump the peer protocol version)

Signed-off-by: JCW <a1q123456@users.noreply.github.com>
@a1q123456
a1q123456 requested review from a team, bthomee and vvysokikh1 and removed request for a team November 19, 2025 15:01
Signed-off-by: JCW <a1q123456@users.noreply.github.com>
@codecov

codecov Bot commented Nov 19, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.6%. Comparing base (b550dc0) to head (3157ef1).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #6054   +/-   ##
=======================================
  Coverage     78.6%   78.6%           
=======================================
  Files          818     818           
  Lines        68953   68938   -15     
  Branches      8244    8237    -7     
=======================================
- Hits         54175   54166    -9     
+ Misses       14778   14772    -6     
Files with missing lines Coverage Δ
src/xrpld/app/paths/RippleCalc.cpp 80.6% <ø> (+5.6%) ⬆️
src/xrpld/app/paths/detail/StrandFlow.h 92.0% <100.0%> (+2.3%) ⬆️

... and 3 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread src/test/app/CrossingLimits_test.cpp Outdated
Comment thread src/test/app/CrossingLimits_test.cpp Outdated
Signed-off-by: JCW <a1q123456@users.noreply.github.com>
Signed-off-by: JCW <a1q123456@users.noreply.github.com>
@a1q123456
a1q123456 requested a review from vvysokikh1 November 24, 2025 10:34
a1q123456 and others added 5 commits November 24, 2025 12:39
Signed-off-by: JCW <a1q123456@users.noreply.github.com>
Signed-off-by: JCW <a1q123456@users.noreply.github.com>
Signed-off-by: JCW <a1q123456@users.noreply.github.com>
Signed-off-by: JCW <a1q123456@users.noreply.github.com>
@bthomee
bthomee enabled auto-merge (squash) November 24, 2025 18:29
@bthomee
bthomee disabled auto-merge November 24, 2025 18:54
Signed-off-by: JCW <a1q123456@users.noreply.github.com>
@a1q123456 a1q123456 added the Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. label Nov 25, 2025
@bthomee
bthomee enabled auto-merge (squash) November 25, 2025 14:01
@bthomee
bthomee merged commit b124c9f into develop Nov 25, 2025
1 check passed
@bthomee
bthomee deleted the a1q123456/retire-Flow branch November 25, 2025 14:21
@mvadari mvadari added this to the 3.2.0 milestone May 20, 2026
beartec-jpg pushed a commit to beartec-jpg/FalconLedger that referenced this pull request Jun 1, 2026
Amendments activated for more than 2 years can be retired. This change retires the Flow and FlowSortStrands amendments.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants