refactor: split up RPCHelpers.h into two - #6047
Merged
Merged
Conversation
mvadari
added
the
Trivial
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #6047 +/- ##
=========================================
- Coverage 78.6% 78.6% -0.0%
=========================================
Files 817 818 +1
Lines 68976 68976
Branches 8242 8239 -3
=========================================
- Hits 54196 54195 -1
- Misses 14780 14781 +1
... and 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
mvadari
added
the
Ready to merge
beartec-jpg
pushed a commit
to beartec-jpg/FalconLedger
that referenced
this pull request
Jun 1, 2026
This PR splits `RPCHelpers.h` into two files, by moving out all the ledger-fetching-related functions into a separate file, `RPCLedgerHelpers.h`. It also moves `getAccountObjects` to `AccountObjects.h`, since it is only used in that one place.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
This PR splits
RPCHelpers.hinto two files, by moving out all the ledger-fetching-related functions into a separate file,RPCLedgerHelpers.h. It also movesgetAccountObjectstoAccountObjects.h, since it is only used in that one place.This PR does not make any functionality changes, just moves code. Code changes are out of scope of this PR and should be included in #5684 instead.
Context of Change
This is a precursor to #5684, to make that PR easier to review.
Type of Change
API Impact
N/A
Test Plan
Tests pass with no changes.