Sponsored Content
Skip to content

Retire DisallowIncoming amendment. - #6045

Merged
bthomee merged 6 commits into
developfrom
pratik/Retire-DisallowIncoming-amendment
Nov 21, 2025
Merged

Retire DisallowIncoming amendment.#6045
bthomee merged 6 commits into
developfrom
pratik/Retire-DisallowIncoming-amendment

Conversation

@pratikmankawde

Copy link
Copy Markdown
Contributor

High Level Overview of Change

This change retires the Disallow Incoming amendment.

Context of Change

Amendments activated for more than 2 years can be retired.
Amendment: https://xrpl.org/resources/known-amendments#disallowincoming

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Performance (increase or change in throughput and/or latency)
  • Tests (you added tests for code that already exists, or your new feature included in this PR)
  • Documentation update
  • Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
  • Release

Signed-off-by: Pratik Mankawde <pmankawde@ripple.com>
@pratikmankawde
pratikmankawde requested review from a team, a1q123456 and vvysokikh1 and removed request for a team November 17, 2025 15:13
Comment thread src/test/app/SetTrust_test.cpp
Comment thread src/xrpld/app/tx/detail/NFTokenUtils.cpp
Comment thread src/xrpld/app/tx/detail/SetTrust.cpp
@a1q123456

Copy link
Copy Markdown
Contributor

left some suggestions

@codecov

codecov Bot commented Nov 17, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 96.87500% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 78.5%. Comparing base (57f4b4e) to head (0c47b20).
⚠️ Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
src/xrpld/app/tx/detail/NFTokenUtils.cpp 85.7% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop   #6045     +/-   ##
=========================================
- Coverage     78.6%   78.5%   -0.0%     
=========================================
  Files          818     818             
  Lines        68989   68981      -8     
  Branches      8245    8266     +21     
=========================================
- Hits         54202   54169     -33     
- Misses       14787   14812     +25     
Files with missing lines Coverage Δ
src/xrpld/app/tx/detail/CreateCheck.cpp 100.0% <100.0%> (ø)
src/xrpld/app/tx/detail/PayChan.cpp 95.3% <100.0%> (-<0.1%) ⬇️
src/xrpld/app/tx/detail/SetAccount.cpp 98.7% <100.0%> (-<0.1%) ⬇️
src/xrpld/app/tx/detail/SetTrust.cpp 95.7% <100.0%> (-<0.1%) ⬇️
src/xrpld/rpc/handlers/AccountInfo.cpp 88.4% <100.0%> (-0.1%) ⬇️
src/xrpld/app/tx/detail/NFTokenUtils.cpp 86.8% <85.7%> (-0.1%) ⬇️

... and 6 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Pratik Mankawde <pmankawde@ripple.com>
Signed-off-by: Pratik Mankawde <pmankawde@ripple.com>
@pratikmankawde

Copy link
Copy Markdown
Contributor Author

Updated code as per review comments.

@a1q123456 a1q123456 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bthomee
bthomee enabled auto-merge (squash) November 21, 2025 14:55
@bthomee
bthomee merged commit e4dccfd into develop Nov 21, 2025
1 check passed
@bthomee
bthomee deleted the pratik/Retire-DisallowIncoming-amendment branch November 21, 2025 15:18
@mvadari mvadari added this to the 3.2.0 milestone May 20, 2026
beartec-jpg pushed a commit to beartec-jpg/FalconLedger that referenced this pull request Jun 1, 2026
Amendments activated for more than 2 years can be retired. This change retires the DisallowIncoming amendment.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants