Retire CryptoConditionsSuite - #6036
Merged
Merged
Conversation
Signed-off-by: JCW <a1q123456@users.noreply.github.com>
Contributor
Author
We're still able to connect to the main net and we don't get amendment blocked after adding a test only feature. |
Collaborator
Bronek
reviewed
Nov 14, 2025
Contributor
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #6036 +/- ##
=========================================
- Coverage 78.6% 78.6% -0.0%
=========================================
Files 818 818
Lines 68981 68978 -3
Branches 8247 8243 -4
=========================================
- Hits 54200 54195 -5
- Misses 14781 14783 +2
... and 4 files with indirect coverage changes 🚀 New features to boost your workflow:
|
ximinez
requested changes
Nov 18, 2025
Signed-off-by: JCW <a1q123456@users.noreply.github.com>
Signed-off-by: JCW <a1q123456@users.noreply.github.com>
bthomee
reviewed
Nov 21, 2025
Signed-off-by: JCW <a1q123456@users.noreply.github.com>
a1q123456
changed the title
ximinez
approved these changes
Nov 21, 2025
| // to vote for it, the feature can be removed (entirely?) from the code. | ||
| XRPL_FEATURE(CryptoConditionsSuite, Supported::yes, VoteBehavior::Obsolete) | ||
|
|
||
| // XRPL_FEATURE(Example, Supported::yes, VoteBehavior::Obsolete) |
Comment on lines
+532
to
+546
| auto const& supportedAmendments = detail::supportedAmendments(); | ||
| auto obsoleteFeature = std::find_if( | ||
| std::begin(supportedAmendments), | ||
| std::end(supportedAmendments), | ||
| [](auto const& pair) { | ||
| return pair.second == VoteBehavior::Obsolete; | ||
| }); | ||
|
|
||
| if (obsoleteFeature == std::end(supportedAmendments)) | ||
| { | ||
| pass(); | ||
| return; | ||
| } | ||
|
|
||
| auto const featureName = obsoleteFeature->first; |
bthomee
reviewed
Nov 23, 2025
bthomee
approved these changes
Nov 23, 2025
a1q123456
added
the
Ready to merge
beartec-jpg
pushed a commit
to beartec-jpg/FalconLedger
that referenced
this pull request
Jun 1, 2026
Amendments activated for more than 2 years can be retired. This change retires the CryptoConditionsSuite amendment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Context of Change
Type of Change
.gitignore, formatting, dropping support for older tooling)API Impact
libxrplchange (any change that may affectlibxrplor dependents oflibxrpl)