Retire RequireFullyCanonicalSig

[a1q123456]

High Level Overview of Change

Context of Change

Type of Change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Refactor (non-breaking change that only restructures code)
• Performance (increase or change in throughput and/or latency)
• Tests (you added tests for code that already exists, or your new feature included in this PR)
• Documentation update
• Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
• Release

API Impact

• Public API: New feature (new methods and/or new fields)
• Public API: Breaking change (in general, breaking changes should only impact the next api_version)
• libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
• Peer protocol change (must be backward compatible or bump the peer protocol version)

[a1q123456]

Adding @ximinez and @Bronek as it's related to Lending Protocol changes.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.6%. Comparing base (a791c03) to head (f44cf67).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files

@@            Coverage Diff            @@
##           develop   #6035     +/-   ##
=========================================
- Coverage     78.6%   78.6%   -0.0%     
=========================================
  Files          818     818             
  Lines        68970   68953     -17     
  Branches      8243    8243             
=========================================
- Hits         54187   54171     -16     
+ Misses       14783   14782      -1     

Files with missing lines	Coverage Δ
include/xrpl/protocol/PublicKey.h	79.1% <ø> (ø)
include/xrpl/protocol/STTx.h	100.0% <ø> (ø)
src/libxrpl/protocol/PublicKey.cpp	91.1% <100.0%> (-0.1%)	⬇️
src/libxrpl/protocol/STTx.cpp	88.0% <100.0%> (-0.4%)	⬇️
src/xrpld/app/tx/detail/Batch.cpp	98.2% <100.0%> (-<0.1%)	⬇️
src/xrpld/app/tx/detail/PayChan.cpp	95.3% <100.0%> (ø)
src/xrpld/app/tx/detail/apply.cpp	92.6% <100.0%> (-0.2%)	⬇️
src/xrpld/rpc/handlers/PayChanClaim.cpp	89.2% <100.0%> (-0.2%)	⬇️

... and 5 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[vvysokikh1]

@a1q123456 I see that there's some cleanup still required in PublicKey.h/.cpp, namely verify and verifyDigest. Or do they still need that parameter?

[a1q123456]

verify

Wasn't very sure if we'll need that in the future but happy to clean them up.