Sponsored Content
Skip to content

Retire NegativeUNL - #6033

Merged
bthomee merged 2 commits into
developfrom
a1q123456/retire-NegativeUNL
Nov 17, 2025
Merged

Retire NegativeUNL#6033
bthomee merged 2 commits into
developfrom
a1q123456/retire-NegativeUNL

Conversation

@a1q123456

Copy link
Copy Markdown
Contributor

High Level Overview of Change

Context of Change

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Performance (increase or change in throughput and/or latency)
  • Tests (you added tests for code that already exists, or your new feature included in this PR)
  • Documentation update
  • Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
  • Release

API Impact

  • Public API: New feature (new methods and/or new fields)
  • Public API: Breaking change (in general, breaking changes should only impact the next api_version)
  • libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
  • Peer protocol change (must be backward compatible or bump the peer protocol version)

Signed-off-by: JCW <a1q123456@users.noreply.github.com>
@a1q123456
a1q123456 requested review from a team, bthomee and vvysokikh1 November 13, 2025 12:35
@codecov

codecov Bot commented Nov 13, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.6%. Comparing base (13a12c6) to head (a06048c).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #6033   +/-   ##
=======================================
  Coverage     78.6%   78.6%           
=======================================
  Files          817     817           
  Lines        68984   68976    -8     
  Branches      8245    8239    -6     
=======================================
- Hits         54201   54199    -2     
+ Misses       14783   14777    -6     
Files with missing lines Coverage Δ
src/xrpld/app/consensus/RCLConsensus.cpp 59.5% <100.0%> (-<0.1%) ⬇️
src/xrpld/app/ledger/detail/BuildLedger.cpp 91.8% <100.0%> (ø)
src/xrpld/app/misc/NetworkOPs.cpp 69.8% <100.0%> (-<0.1%) ⬇️
src/xrpld/app/tx/detail/Change.cpp 85.6% <ø> (-0.3%) ⬇️

... and 5 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@a1q123456 a1q123456 added Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. Added to API Changelog API changes have been documented in API-CHANGELOG.md and removed Added to API Changelog API changes have been documented in API-CHANGELOG.md Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. labels Nov 17, 2025
…egativeUNL

Signed-off-by: JCW <a1q123456@users.noreply.github.com>

# Conflicts:
#	include/xrpl/protocol/detail/features.macro
@a1q123456 a1q123456 added the Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. label Nov 17, 2025
@bthomee
bthomee enabled auto-merge (squash) November 17, 2025 13:34
@bthomee
bthomee merged commit 2c18746 into develop Nov 17, 2025
1 check passed
@bthomee
bthomee deleted the a1q123456/retire-NegativeUNL branch November 17, 2025 14:02
@mvadari mvadari added this to the 3.2.0 milestone May 20, 2026
beartec-jpg pushed a commit to beartec-jpg/FalconLedger that referenced this pull request Jun 1, 2026
Amendments activated for more than 2 years can be retired. This change retires the NegativeUNL amendment.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants