Fix array size check - #6030
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #6030 +/- ##
=======================================
Coverage 78.6% 78.6%
=======================================
Files 818 818
Lines 68976 68983 +7
Branches 8267 8245 -22
=======================================
+ Hits 54190 54196 +6
- Misses 14786 14787 +1
... and 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
kuznetsss
reviewed
Nov 14, 2025
oleks-rip
force-pushed
the
fix_cred_array
branch
6 times, most recently
from
November 17, 2025 20:07
32d7658 to
9a5d1cf
Compare
mvadari
approved these changes
Nov 17, 2025
mvadari
left a comment
mvadari
left a comment
Contributor
There was a problem hiding this comment.
Does the API changelog need to be updated?
oleks-rip
force-pushed
the
fix_cred_array
branch
from
November 18, 2025 19:53
9a5d1cf to
78fc431
Compare
oleks-rip
added
the
Ready to merge
bthomee
removed
the
Ready to merge
bthomee
added
the
Ready to merge
bthomee
enabled auto-merge (squash)
November 19, 2025 16:37
bthomee
added
the
QE test desired
bthomee
pushed a commit
that referenced
this pull request
Apr 7, 2026
The `ledger_entry` and `deposit_preauth` requests require an array of credentials. However, the array size is not checked before is gets processing. This fix adds checks and return errors in case array size is too big.
ximinez
pushed a commit
that referenced
this pull request
Apr 10, 2026
The `ledger_entry` and `deposit_preauth` requests require an array of credentials. However, the array size is not checked before is gets processing. This fix adds checks and return errors in case array size is too big.
ximinez
pushed a commit
that referenced
this pull request
Apr 22, 2026
The `ledger_entry` and `deposit_preauth` requests require an array of credentials. However, the array size is not checked before is gets processing. This fix adds checks and return errors in case array size is too big.
beartec-jpg
pushed a commit
to beartec-jpg/FalconLedger
that referenced
this pull request
Jun 1, 2026
The `ledger_entry` and `deposit_preauth` requests require an array of credentials. However, the array size is not checked before is gets processing. This fix adds checks and return errors in case array size is too big.
32 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
ledger_entrydeposit_preauthrequest require array of credentials. Array size is not checked before processing the array.This fix add check and return error in case array size is too big.
Context of Change
See RXI-1857 for more details
Type of Change
.gitignore, formatting, dropping support for older tooling)