Sponsored Content
Skip to content

Update RocksDB, SQLite, Doctest - #6015

Merged
bthomee merged 2 commits into
developfrom
bthomee/update
Nov 10, 2025
Merged

Update RocksDB, SQLite, Doctest#6015
bthomee merged 2 commits into
developfrom
bthomee/update

Conversation

@bthomee

@bthomee bthomee commented Nov 7, 2025

Copy link
Copy Markdown
Collaborator

High Level Overview of Change

This PR updates a few of our dependencies.

Context of Change

To ensure we leverage security and performance improvements, we perform periodic updates of our dependencies. I note that SOCI and Snappy also have updates, but those require patches and will therefore be done in a separate PR.

After applying these updates, I ran rippled both with NuDB and RocksDB and was successfully able to sync to testnet.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Performance (increase or change in throughput and/or latency)
  • Tests (you added tests for code that already exists, or your new feature included in this PR)
  • Documentation update
  • Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
  • Release

@codecov

codecov Bot commented Nov 7, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.6%. Comparing base (3b810c3) to head (82c11cf).
⚠️ Report is 136 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop   #6015     +/-   ##
=========================================
- Coverage     78.6%   78.6%   -0.0%     
=========================================
  Files          817     817             
  Lines        69023   69024      +1     
  Branches      8239    8242      +3     
=========================================
  Hits         54252   54252             
- Misses       14771   14772      +1     

see 4 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@a1q123456 a1q123456 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice if we could deploy a test net and a live net server to soak test those changes.

@bthomee

bthomee commented Nov 10, 2025

Copy link
Copy Markdown
Collaborator Author

Would be nice if we could deploy a test net and a live net server to soak test those changes.

Yes. With the OpenSSL 1.x to 3.x upgrade we need to do so already. Once 3.0.0 is out we can deploy one node with optimized NuDB settings and one with optimized RocksDB settings.

@pratikmankawde pratikmankawde left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bthomee
bthomee enabled auto-merge (squash) November 10, 2025 17:37
@bthomee
bthomee merged commit 098eadc into develop Nov 10, 2025
1 check passed
@bthomee
bthomee deleted the bthomee/update branch November 10, 2025 18:02
@bthomee bthomee added the QE test desired RippleX QE Team should consider looking at this PR. label Feb 11, 2026
@mvadari mvadari added this to the 3.2.0 milestone May 20, 2026
beartec-jpg pushed a commit to beartec-jpg/FalconLedger that referenced this pull request Jun 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

QE test desired RippleX QE Team should consider looking at this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants