Sponsored Content
Skip to content

refactor: Add XRPL_RETIRE_FIX and XRPL_RETIRE_FEATURE - #6014

Merged
bthomee merged 8 commits into
developfrom
a1q123456/add-retire-feature-and-fix
Nov 11, 2025
Merged

refactor: Add XRPL_RETIRE_FIX and XRPL_RETIRE_FEATURE#6014
bthomee merged 8 commits into
developfrom
a1q123456/add-retire-feature-and-fix

Conversation

@a1q123456

Copy link
Copy Markdown
Contributor

High Level Overview of Change

This PR makes it more clear by replacing XRPL_RETIRE with XRPL_RETIRE_FIX and XRPL_RETIRE_FEATURE.

Context of Change

Once we got confused because we didn't know whether we should prefix the feature amendments we retired with feature in XRPL_RETIRE() in features.macro, because we prefix retired fix amendments with fix.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Performance (increase or change in throughput and/or latency)
  • Tests (you added tests for code that already exists, or your new feature included in this PR)
  • Documentation update
  • Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
  • Release

API Impact

  • Public API: New feature (new methods and/or new fields)
  • Public API: Breaking change (in general, breaking changes should only impact the next api_version)
  • libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
  • Peer protocol change (must be backward compatible or bump the peer protocol version)

Signed-off-by: JCW <a1q123456@users.noreply.github.com>
@a1q123456 a1q123456 added DraftRunCI Normally CI does not run on draft PRs. This opts in. and removed DraftRunCI Normally CI does not run on draft PRs. This opts in. labels Nov 7, 2025
@a1q123456
a1q123456 marked this pull request as ready for review November 10, 2025 13:43
@a1q123456
a1q123456 requested review from a team, pratikmankawde and ximinez November 10, 2025 13:43
@codecov

codecov Bot commented Nov 10, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.6%. Comparing base (ff18cfe) to head (662b3aa).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #6014   +/-   ##
=======================================
  Coverage     78.6%   78.6%           
=======================================
  Files          817     817           
  Lines        68995   68995           
  Branches      8239    8239           
=======================================
  Hits         54221   54221           
  Misses       14774   14774           
Files with missing lines Coverage Δ
include/xrpl/protocol/Feature.h 97.9% <ø> (ø)
src/libxrpl/protocol/Feature.cpp 94.6% <ø> (ø)

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread src/libxrpl/protocol/Feature.cpp Outdated
Signed-off-by: JCW <a1q123456@users.noreply.github.com>
Comment thread src/libxrpl/protocol/Feature.cpp Outdated
Comment thread src/libxrpl/protocol/Feature.cpp Outdated
Comment thread include/xrpl/protocol/detail/features.macro Outdated
a1q123456 and others added 3 commits November 10, 2025 21:57
Co-authored-by: Bart <bthomee@users.noreply.github.com>
Co-authored-by: Bart <bthomee@users.noreply.github.com>
Co-authored-by: Bart <bthomee@users.noreply.github.com>
Comment thread src/libxrpl/protocol/Feature.cpp Outdated
Signed-off-by: JCW <a1q123456@users.noreply.github.com>
Signed-off-by: JCW <a1q123456@users.noreply.github.com>
@a1q123456 a1q123456 added the Needs additional review PR requires at least one more code review approval before it can be merged label Nov 11, 2025
Signed-off-by: JCW <a1q123456@users.noreply.github.com>

@pratikmankawde pratikmankawde left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@a1q123456 a1q123456 added Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. and removed Needs additional review PR requires at least one more code review approval before it can be merged labels Nov 11, 2025
@Bronek Bronek changed the title Add XRPL_RETIRE_FIX and XRPL_RETIRE_FEATURE refactor: Add XRPL_RETIRE_FIX and XRPL_RETIRE_FEATURE Nov 11, 2025
@bthomee
bthomee merged commit 9ffb434 into develop Nov 11, 2025
3 checks passed
@bthomee
bthomee deleted the a1q123456/add-retire-feature-and-fix branch November 11, 2025 17:45
@mvadari mvadari added this to the 3.2.0 milestone May 20, 2026
beartec-jpg pushed a commit to beartec-jpg/FalconLedger that referenced this pull request Jun 1, 2026
…LF#6014)

Rather than having a single `XRPL_RETIRE` macro that applies to both feature and fix amendments, this change replaces it by new `XRPL_RETIRE_FIX` and `XRPL_RETIRE_FEATURE` macros that avoids confusion between whether to prefix the amendment name with `feature` or `fix`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants