refactor: Add XRPL_RETIRE_FIX and XRPL_RETIRE_FEATURE - #6014
Merged
Conversation
Signed-off-by: JCW <a1q123456@users.noreply.github.com>
a1q123456
marked this pull request as ready for review
November 10, 2025 13:43
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #6014 +/- ##
=======================================
Coverage 78.6% 78.6%
=======================================
Files 817 817
Lines 68995 68995
Branches 8239 8239
=======================================
Hits 54221 54221
Misses 14774 14774
🚀 New features to boost your workflow:
|
Signed-off-by: JCW <a1q123456@users.noreply.github.com>
bthomee
reviewed
Nov 10, 2025
Co-authored-by: Bart <bthomee@users.noreply.github.com>
Co-authored-by: Bart <bthomee@users.noreply.github.com>
Co-authored-by: Bart <bthomee@users.noreply.github.com>
bthomee
reviewed
Nov 10, 2025
bthomee
approved these changes
Nov 10, 2025
Signed-off-by: JCW <a1q123456@users.noreply.github.com>
beartec-jpg
pushed a commit
to beartec-jpg/FalconLedger
that referenced
this pull request
Jun 1, 2026
…LF#6014) Rather than having a single `XRPL_RETIRE` macro that applies to both feature and fix amendments, this change replaces it by new `XRPL_RETIRE_FIX` and `XRPL_RETIRE_FEATURE` macros that avoids confusion between whether to prefix the amendment name with `feature` or `fix`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
This PR makes it more clear by replacing XRPL_RETIRE with XRPL_RETIRE_FIX and XRPL_RETIRE_FEATURE.
Context of Change
Once we got confused because we didn't know whether we should prefix the feature amendments we retired with
featureinXRPL_RETIRE()infeatures.macro, because we prefix retired fix amendments withfix.Type of Change
.gitignore, formatting, dropping support for older tooling)API Impact
libxrplchange (any change that may affectlibxrplor dependents oflibxrpl)