chore: Removes unnecessary creation of symlink in CMake install file - #6009
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #6009 +/- ##
=======================================
Coverage 78.3% 78.3%
=======================================
Files 816 816
Lines 68887 68887
Branches 8304 8304
=======================================
Hits 53942 53942
Misses 14945 14945 🚀 New features to boost your workflow:
|
beartec-jpg
pushed a commit
to beartec-jpg/FalconLedger
that referenced
this pull request
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
This change removes the creation of a symlink that after #5975 results in errors, by updating the renaming script.
Context of Change
The changes in #5975 renamed ripple(d) to xrpl(d) in CMake files. Previously, changes had already been made in anticipation of this renaming, whereby a symlink "ripple" was made to point to "xrpl". Now after renaming, "ripple" has become "xrpl" and a symlink is attempted to be made from "xrpl" to "xrpl", which therefore fails. This symlink is thus now no longer needed, and can be removed.
Type of Change
.gitignore, formatting, dropping support for older tooling)