Sponsored Content
Skip to content

chore: Removes unnecessary creation of symlink in CMake install file - #6009

Merged
bthomee merged 2 commits into
developfrom
bthomee/cmake
Nov 6, 2025
Merged

chore: Removes unnecessary creation of symlink in CMake install file#6009
bthomee merged 2 commits into
developfrom
bthomee/cmake

Conversation

@bthomee

@bthomee bthomee commented Nov 6, 2025

Copy link
Copy Markdown
Collaborator

High Level Overview of Change

This change removes the creation of a symlink that after #5975 results in errors, by updating the renaming script.

Context of Change

The changes in #5975 renamed ripple(d) to xrpl(d) in CMake files. Previously, changes had already been made in anticipation of this renaming, whereby a symlink "ripple" was made to point to "xrpl". Now after renaming, "ripple" has become "xrpl" and a symlink is attempted to be made from "xrpl" to "xrpl", which therefore fails. This symlink is thus now no longer needed, and can be removed.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Performance (increase or change in throughput and/or latency)
  • Tests (you added tests for code that already exists, or your new feature included in this PR)
  • Documentation update
  • Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
  • Release

@bthomee
bthomee requested review from a1q123456 and legleux November 6, 2025 08:31

@a1q123456 a1q123456 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov

codecov Bot commented Nov 6, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.3%. Comparing base (28a1f90) to head (92e80ed).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #6009   +/-   ##
=======================================
  Coverage     78.3%   78.3%           
=======================================
  Files          816     816           
  Lines        68887   68887           
  Branches      8304    8304           
=======================================
  Hits         53942   53942           
  Misses       14945   14945           

see 4 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bthomee bthomee added the Trivial Simple change with minimal effect, or already tested. Only needs one approval. label Nov 6, 2025
@bthomee
bthomee merged commit 173f9f7 into develop Nov 6, 2025
3 checks passed
@bthomee
bthomee deleted the bthomee/cmake branch November 6, 2025 09:06
@mvadari mvadari added this to the 3.2.0 milestone May 20, 2026
beartec-jpg pushed a commit to beartec-jpg/FalconLedger that referenced this pull request Jun 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Trivial Simple change with minimal effect, or already tested. Only needs one approval.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants