Sponsored Content
Skip to content

Retire HardenedValidations - #5988

Merged
bthomee merged 2 commits into
developfrom
a1q123456/retire-HardenedValidations
Nov 4, 2025
Merged

Retire HardenedValidations#5988
bthomee merged 2 commits into
developfrom
a1q123456/retire-HardenedValidations

Conversation

@a1q123456

Copy link
Copy Markdown
Contributor

High Level Overview of Change

Context of Change

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Performance (increase or change in throughput and/or latency)
  • Tests (you added tests for code that already exists, or your new feature included in this PR)
  • Documentation update
  • Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
  • Release

API Impact

  • Public API: New feature (new methods and/or new fields)
  • Public API: Breaking change (in general, breaking changes should only impact the next api_version)
  • libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
  • Peer protocol change (must be backward compatible or bump the peer protocol version)

Signed-off-by: JCW <a1q123456@users.noreply.github.com>
@a1q123456
a1q123456 requested review from a team, bthomee and vvysokikh1 November 3, 2025 15:39
@codecov

codecov Bot commented Nov 3, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.2%. Comparing base (f3a2ec1) to head (0c91793).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop   #5988     +/-   ##
=========================================
- Coverage     78.2%   78.2%   -0.0%     
=========================================
  Files          816     816             
  Lines        68949   68948      -1     
  Branches      8352    8352             
=========================================
- Hits         53945   53943      -2     
- Misses       15004   15005      +1     
Files with missing lines Coverage Δ
src/libxrpl/protocol/STValidation.cpp 81.8% <ø> (ø)
src/xrpld/app/consensus/RCLConsensus.cpp 59.5% <100.0%> (-0.1%) ⬇️
src/xrpld/app/ledger/detail/LedgerMaster.cpp 41.5% <ø> (ø)

... and 1 file with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

…ardenedValidations

Signed-off-by: JCW <a1q123456@users.noreply.github.com>

# Conflicts:
#	include/xrpl/protocol/detail/features.macro
@bthomee
bthomee merged commit f28ba57 into develop Nov 4, 2025
3 checks passed
@bthomee
bthomee deleted the a1q123456/retire-HardenedValidations branch November 4, 2025 17:04
@mvadari mvadari added this to the 3.2.0 milestone May 20, 2026
beartec-jpg pushed a commit to beartec-jpg/FalconLedger that referenced this pull request Jun 1, 2026
Amendments activated for more than 2 years can be retired. This change retires the HardenedValidations amendment.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants