Sponsored Content
Skip to content

chore: Remove version number in find_dependency for OpenSSL - #5985

Merged
bthomee merged 1 commit into
developfrom
bthomee/openssl
Nov 3, 2025
Merged

chore: Remove version number in find_dependency for OpenSSL#5985
bthomee merged 1 commit into
developfrom
bthomee/openssl

Conversation

@bthomee

@bthomee bthomee commented Nov 3, 2025

Copy link
Copy Markdown
Collaborator

High Level Overview of Change

This change removes the unnecessary version number in find_dependency(OpenSSL ...).

Context of Change

We are already using OpenSSL 3.5.2. The version number in the find_dependency statement is optional, and belongs in conanfile.py anyway.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Performance (increase or change in throughput and/or latency)
  • Tests (you added tests for code that already exists, or your new feature included in this PR)
  • Documentation update
  • Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
  • Release

@bthomee bthomee added the Trivial Simple change with minimal effect, or already tested. Only needs one approval. label Nov 3, 2025
@bthomee
bthomee requested review from Bronek and vvysokikh1 November 3, 2025 11:09
@bthomee
bthomee enabled auto-merge (squash) November 3, 2025 11:25
@codecov

codecov Bot commented Nov 3, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.3%. Comparing base (8eb233c) to head (004e175).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop   #5985     +/-   ##
=========================================
- Coverage     78.3%   78.3%   -0.0%     
=========================================
  Files          817     817             
  Lines        69001   69001             
  Branches      8342    8343      +1     
=========================================
- Hits         54021   54016      -5     
- Misses       14980   14985      +5     

see 2 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bthomee
bthomee merged commit 25c5e3b into develop Nov 3, 2025
3 checks passed
@bthomee
bthomee deleted the bthomee/openssl branch November 3, 2025 13:53
@mvadari mvadari added this to the 3.2.0 milestone May 20, 2026
beartec-jpg pushed a commit to beartec-jpg/FalconLedger that referenced this pull request Jun 1, 2026
We are already using OpenSSL 3.5.2. The version number in the `find_dependency` statement is optional, and belongs in `conanfile.py` anyway.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Trivial Simple change with minimal effect, or already tested. Only needs one approval.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants