Sponsored Content
Skip to content

Retire DepositPreAuth and DepositAuth - #5978

Merged
bthomee merged 5 commits into
developfrom
a1q123456/retire-DepositPreAuth
Nov 11, 2025
Merged

Retire DepositPreAuth and DepositAuth#5978
bthomee merged 5 commits into
developfrom
a1q123456/retire-DepositPreAuth

Conversation

@a1q123456

@a1q123456 a1q123456 commented Oct 31, 2025

Copy link
Copy Markdown
Contributor

High Level Overview of Change

Context of Change

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Performance (increase or change in throughput and/or latency)
  • Tests (you added tests for code that already exists, or your new feature included in this PR)
  • Documentation update
  • Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
  • Release

API Impact

  • Public API: New feature (new methods and/or new fields)
  • Public API: Breaking change (in general, breaking changes should only impact the next api_version)
  • libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
  • Peer protocol change (must be backward compatible or bump the peer protocol version)

@a1q123456
a1q123456 requested review from a team, bthomee and pratikmankawde October 31, 2025 15:07
@a1q123456 a1q123456 changed the title Retire DepositPreAuth Retire DepositPreAuth and DepositAuth Oct 31, 2025
Comment thread src/test/app/DepositAuth_test.cpp Outdated
@codecov

codecov Bot commented Oct 31, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 97.22222% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 78.6%. Comparing base (03704f7) to head (def6790).
⚠️ Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
src/xrpld/app/tx/detail/CreateOffer.cpp 66.7% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop   #5978     +/-   ##
=========================================
- Coverage     78.6%   78.6%   -0.0%     
=========================================
  Files          817     817             
  Lines        69021   68995     -26     
  Branches      8240    8243      +3     
=========================================
- Hits         54246   54217     -29     
- Misses       14775   14778      +3     
Files with missing lines Coverage Δ
include/xrpl/protocol/detail/transactions.macro 100.0% <ø> (ø)
src/xrpld/app/tx/detail/DeleteAccount.cpp 94.4% <100.0%> (-0.1%) ⬇️
src/xrpld/app/tx/detail/Escrow.cpp 99.2% <100.0%> (-<0.1%) ⬇️
src/xrpld/app/tx/detail/PayChan.cpp 95.3% <100.0%> (-0.2%) ⬇️
src/xrpld/app/tx/detail/Payment.cpp 93.6% <100.0%> (-0.1%) ⬇️
src/xrpld/app/tx/detail/SetAccount.cpp 98.7% <100.0%> (-<0.1%) ⬇️
src/xrpld/app/tx/detail/CreateOffer.cpp 93.4% <66.7%> (+0.4%) ⬆️

... and 3 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@a1q123456
a1q123456 requested a review from bthomee November 1, 2025 09:07
Comment thread src/test/rpc/AccountSet_test.cpp Outdated
@a1q123456
a1q123456 requested a review from bthomee November 3, 2025 10:59
@a1q123456 a1q123456 added the Needs additional review PR requires at least one more code review approval before it can be merged label Nov 5, 2025
@pratikmankawde

Copy link
Copy Markdown
Contributor

LGTM

@pratikmankawde pratikmankawde left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bthomee bthomee added Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. and removed Needs additional review PR requires at least one more code review approval before it can be merged labels Nov 10, 2025
@bthomee
bthomee enabled auto-merge (squash) November 10, 2025 18:14
@bthomee
bthomee disabled auto-merge November 10, 2025 18:25
Signed-off-by: JCW <a1q123456@users.noreply.github.com>
Signed-off-by: JCW <a1q123456@users.noreply.github.com>
Signed-off-by: JCW <a1q123456@users.noreply.github.com>
@a1q123456
a1q123456 force-pushed the a1q123456/retire-DepositPreAuth branch from 8db293b to 4fd4b37 Compare November 10, 2025 18:37
Signed-off-by: JCW <a1q123456@users.noreply.github.com>
@a1q123456
a1q123456 force-pushed the a1q123456/retire-DepositPreAuth branch from 29db0b6 to d0393e6 Compare November 11, 2025 13:50
@a1q123456
a1q123456 requested a review from bthomee November 11, 2025 13:51
@a1q123456 a1q123456 added Needs additional review PR requires at least one more code review approval before it can be merged and removed Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. labels Nov 11, 2025
@bthomee bthomee removed the Needs additional review PR requires at least one more code review approval before it can be merged label Nov 11, 2025
@a1q123456 a1q123456 added the Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. label Nov 11, 2025
@bthomee
bthomee enabled auto-merge (squash) November 11, 2025 15:01
@bthomee
bthomee merged commit ff18cfe into develop Nov 11, 2025
1 check passed
@bthomee
bthomee deleted the a1q123456/retire-DepositPreAuth branch November 11, 2025 15:21
@mvadari mvadari added this to the 3.2.0 milestone May 20, 2026
beartec-jpg pushed a commit to beartec-jpg/FalconLedger that referenced this pull request Jun 1, 2026
Amendments activated for more than 2 years can be retired. This change retires the fDepositPreAuth and DepositAuth amendments.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants