Retire CheckCashMakesTrustLine - #5974
Merged
Merged
Conversation
Signed-off-by: JCW <a1q123456@users.noreply.github.com>
a1q123456
force-pushed
the
a1q123456/retire-CheckCashMakesTrustLine
branch
from
October 30, 2025 17:36
6805037 to
cdd76b8
Compare
bthomee
reviewed
Oct 30, 2025
bthomee
left a comment
bthomee
left a comment
Collaborator
There was a problem hiding this comment.
There's a compilation failure. I'll review once that's been fixed.
Signed-off-by: JCW <a1q123456@users.noreply.github.com>
Signed-off-by: JCW <a1q123456@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #5974 +/- ##
=========================================
Coverage ? 78.6%
=========================================
Files ? 817
Lines ? 68995
Branches ? 8241
=========================================
Hits ? 54221
Misses ? 14774
Partials ? 0
🚀 New features to boost your workflow:
|
bthomee
approved these changes
Oct 31, 2025
a1q123456
added
the
Needs additional review
dangell7
requested changes
Oct 31, 2025
bthomee
removed
the
Needs additional review
Signed-off-by: JCW <a1q123456@users.noreply.github.com>
Signed-off-by: JCW <a1q123456@users.noreply.github.com>
Signed-off-by: JCW <a1q123456@users.noreply.github.com>
bthomee
approved these changes
Nov 5, 2025
a1q123456
added
the
Needs additional review
…heckCashMakesTrustLine Signed-off-by: JCW <a1q123456@users.noreply.github.com> # Conflicts: # include/xrpl/protocol/detail/features.macro
Comment on lines
+170
to
173
| auto const sleTrustLine = | ||
| ctx.view.read(keylet::line(dstId, issuerId, currency)); | ||
|
|
||
| if (!sleTrustLine) |
Contributor
There was a problem hiding this comment.
Minor suggestion: I would have preferred to keep this initialisation and check as early as possible instead of moving it in.
Contributor
Author
There was a problem hiding this comment.
I think this is better as only this block needs the trust line here and it's not related to other part of the logic.
dangell7
approved these changes
Nov 10, 2025
a1q123456
added
Ready to merge
bthomee
enabled auto-merge (squash)
November 10, 2025 15:33
beartec-jpg
pushed a commit
to beartec-jpg/FalconLedger
that referenced
this pull request
Jun 1, 2026
Amendments activated for more than 2 years can be retired. This change retires the CheckCashMakesTrustLine amendment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Context of Change
Type of Change
.gitignore, formatting, dropping support for older tooling)API Impact
libxrplchange (any change that may affectlibxrplor dependents oflibxrpl)