Sponsored Content
Skip to content

Retire ImmediateOfferKilled - #5973

Merged
bthomee merged 4 commits into
developfrom
a1q123456/retire-ImmediateOfferKilled
Nov 3, 2025
Merged

Retire ImmediateOfferKilled#5973
bthomee merged 4 commits into
developfrom
a1q123456/retire-ImmediateOfferKilled

Conversation

@a1q123456

@a1q123456 a1q123456 commented Oct 30, 2025

Copy link
Copy Markdown
Contributor

High Level Overview of Change

Context of Change

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Performance (increase or change in throughput and/or latency)
  • Tests (you added tests for code that already exists, or your new feature included in this PR)
  • Documentation update
  • Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
  • Release

API Impact

  • Public API: New feature (new methods and/or new fields)
  • Public API: Breaking change (in general, breaking changes should only impact the next api_version)
  • libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
  • Peer protocol change (must be backward compatible or bump the peer protocol version)

Signed-off-by: JCW <a1q123456@users.noreply.github.com>
@a1q123456
a1q123456 requested review from a team, bthomee and pratikmankawde and removed request for a team October 30, 2025 17:25
Comment thread include/xrpl/protocol/detail/features.macro Outdated
Comment thread src/test/app/Offer_test.cpp
@codecov

codecov Bot commented Oct 30, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.3%. Comparing base (12c4b5a) to head (fd8ca10).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #5973   +/-   ##
=======================================
  Coverage     78.3%   78.3%           
=======================================
  Files          817     817           
  Lines        69001   69001           
  Branches      8339    8338    -1     
=======================================
+ Hits         54021   54023    +2     
+ Misses       14980   14978    -2     
Files with missing lines Coverage Δ
src/xrpld/app/tx/detail/CreateOffer.cpp 92.9% <100.0%> (ø)

... and 2 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: JCW <a1q123456@users.noreply.github.com>
@a1q123456
a1q123456 requested a review from bthomee October 31, 2025 11:20
@a1q123456 a1q123456 added the Needs additional review PR requires at least one more code review approval before it can be merged label Oct 31, 2025
Comment thread src/xrpld/app/tx/detail/CreateOffer.cpp Outdated
@bthomee bthomee removed the Needs additional review PR requires at least one more code review approval before it can be merged label Oct 31, 2025
Signed-off-by: JCW <a1q123456@users.noreply.github.com>
@a1q123456 a1q123456 added the Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. label Nov 3, 2025
@bthomee
bthomee enabled auto-merge (squash) November 3, 2025 17:02
@bthomee
bthomee merged commit 8ac8a47 into develop Nov 3, 2025
3 checks passed
@bthomee
bthomee deleted the a1q123456/retire-ImmediateOfferKilled branch November 3, 2025 17:26
@mvadari mvadari added this to the 3.2.0 milestone May 20, 2026
beartec-jpg pushed a commit to beartec-jpg/FalconLedger that referenced this pull request Jun 1, 2026
Amendments activated for more than 2 years can be retired. This change retires the ImmediateOfferKilled amendment.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants