Retire fixAmendmentMajorityCalc - #5961
Merged
Merged
Conversation
a1q123456
requested review from
a team,
pratikmankawde and
vvysokikh1
and removed request for
a team
October 29, 2025 14:27
Signed-off-by: JCW <a1q123456@users.noreply.github.com>
a1q123456
force-pushed
the
a1q123456/retire-fixAmendmentMajorityCalc
branch
from
October 29, 2025 14:32
839b140 to
4e5bd13
Compare
|
|
||
| constexpr std::ratio<80, 100> postFixAmendmentMajorityCalcThreshold; | ||
| /** The minimum amount of support an amendment should have. */ | ||
| constexpr std::ratio<80, 100> amendmentMajorityCalcThreshold; |
Contributor
There was a problem hiding this comment.
Is there no naming convention for the constexpr global variable? Also, can it be moved to cpp file?
Contributor
Author
There was a problem hiding this comment.
i’d rather having it defined here as this file defines system parameters. And yeah, I do think those variable names are a bit messy, some of them are all uppercase and some of them are different. I think we should refactor them in the future
vvysokikh1
reviewed
Oct 29, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #5961 +/- ##
=========================================
- Coverage 78.3% 78.3% -0.0%
=========================================
Files 817 817
Lines 69003 68978 -25
Branches 8318 8319 +1
=========================================
- Hits 54028 54007 -21
+ Misses 14975 14971 -4
... and 5 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Signed-off-by: JCW <a1q123456@users.noreply.github.com>
Signed-off-by: JCW <a1q123456@users.noreply.github.com>
vvysokikh1
reviewed
Oct 31, 2025
Signed-off-by: JCW <a1q123456@users.noreply.github.com>
dangell7
approved these changes
Oct 31, 2025
a1q123456
added
the
Ready to merge
bthomee
enabled auto-merge (squash)
October 31, 2025 17:26
bthomee
disabled auto-merge
October 31, 2025 17:27
bthomee
reviewed
Oct 31, 2025
bthomee
enabled auto-merge (squash)
October 31, 2025 19:35
beartec-jpg
pushed a commit
to beartec-jpg/FalconLedger
that referenced
this pull request
Jun 1, 2026
Amendments activated for more than 2 years can be retired. This change retires the fixAmendmentMajorityCalc amendment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Context of Change
Type of Change
.gitignore, formatting, dropping support for older tooling)API Impact
libxrplchange (any change that may affectlibxrplor dependents oflibxrpl)