Sponsored Content
Skip to content

Retire fixQualityUpperBound amendment - #5960

Merged
bthomee merged 4 commits into
developfrom
pratik/Retire_fixQualityUpperBound_amendment
Oct 30, 2025
Merged

Retire fixQualityUpperBound amendment#5960
bthomee merged 4 commits into
developfrom
pratik/Retire_fixQualityUpperBound_amendment

Conversation

@pratikmankawde

Copy link
Copy Markdown
Contributor

High Level Overview of Change

This change retires the fixQualityUpperBound amendment.

Context of Change

Amendments activated for more than 2 years can be retired.
https://xrpl.org/resources/known-amendments#fixQualityUpperBound

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Performance (increase or change in throughput and/or latency)
  • Tests (you added tests for code that already exists, or your new feature included in this PR)
  • Documentation update
  • Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
  • Release

Signed-off-by: Pratik Mankawde <pmankawde@ripple.com>
@pratikmankawde
pratikmankawde requested review from a team, bthomee and vvysokikh1 October 29, 2025 14:06
@bthomee bthomee added the Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. label Oct 29, 2025
@bthomee
bthomee enabled auto-merge (squash) October 30, 2025 17:42
@bthomee
bthomee merged commit b39d7a6 into develop Oct 30, 2025
1 check passed
@bthomee
bthomee deleted the pratik/Retire_fixQualityUpperBound_amendment branch October 30, 2025 18:47
@codecov

codecov Bot commented Oct 31, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.3%. Comparing base (b0910e3) to head (fb80318).
⚠️ Report is 4 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #5960   +/-   ##
=======================================
  Coverage     78.3%   78.3%           
=======================================
  Files          817     817           
  Lines        68928   68916   -12     
  Branches      8304    8298    -6     
=======================================
  Hits         53974   53974           
+ Misses       14954   14942   -12     
Files with missing lines Coverage Δ
src/xrpld/app/paths/detail/DirectStep.cpp 83.1% <ø> (+2.4%) ⬆️

... and 1 file with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mvadari mvadari added this to the 3.2.0 milestone May 20, 2026
beartec-jpg pushed a commit to beartec-jpg/FalconLedger that referenced this pull request Jun 1, 2026
Amendments activated for more than 2 years can be retired. This change retires the fixQualityUpperBound amendment.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants