Retire fixMasterKeyAsRegularKey - #5959
Merged
Merged
Conversation
a1q123456
requested review from
a team,
pratikmankawde and
vvysokikh1
and removed request for
a team
October 29, 2025 14:06
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #5959 +/- ##
=========================================
- Coverage 78.3% 78.3% -0.0%
=========================================
Files 817 817
Lines 68989 68948 -41
Branches 8320 8318 -2
=========================================
- Hits 54015 53977 -38
+ Misses 14974 14971 -3
🚀 New features to boost your workflow:
|
Signed-off-by: JCW <a1q123456@users.noreply.github.com>
a1q123456
force-pushed
the
a1q123456/retire-fixMasterKeyAsRegularKey
branch
from
October 29, 2025 14:34
6456c76 to
cb63abe
Compare
vvysokikh1
approved these changes
Oct 29, 2025
dangell7
approved these changes
Oct 31, 2025
bthomee
reviewed
Oct 31, 2025
bthomee
reviewed
Oct 31, 2025
bthomee
enabled auto-merge (squash)
October 31, 2025 20:27
beartec-jpg
pushed a commit
to beartec-jpg/FalconLedger
that referenced
this pull request
Jun 1, 2026
Amendments activated for more than 2 years can be retired. This change retires the fixMasterKeyAsRegularKey amendment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Context of Change
Type of Change
.gitignore, formatting, dropping support for older tooling)API Impact
libxrplchange (any change that may affectlibxrplor dependents oflibxrpl)