Retire fixTakerDryOfferRemoval amendment

[pratikmankawde]

High Level Overview of Change

This change retires the fixTakerDryOfferRemoval amendment.

Context of Change

Amendments activated for more than 2 years can be retired.
https://xrpl.org/resources/known-amendments#fixTakerDryOfferRemoval

Type of Change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Refactor (non-breaking change that only restructures code)
• Performance (increase or change in throughput and/or latency)
• Tests (you added tests for code that already exists, or your new feature included in this PR)
• Documentation update
• Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
• Release

[bthomee]

It looks like this fix amendment had implicitly already been permanently enabled due to other changes in the past.

[bthomee]

@pratikmankawde I don't see why, but the OfferAllFeatures test is failing consistently. Can you please take a look?

On Linux I see Suite: ripple.app.OfferAllFeatures failed to complete. The child process may have crashed. everywhere, while on Windows it shows that the test fails with 20 errors; the macOS runner is currently broken, so no results are available there.

[pratikmankawde]

@pratikmankawde I don't see why, but the OfferAllFeatures test is failing consistently. Can you please take a look?

On Linux I see Suite: ripple.app.OfferAllFeatures failed to complete. The child process may have crashed. everywhere, while on Windows it shows that the test fails with 20 errors; the macOS runner is currently broken, so no results are available there.

I made the fixes and tested locally. Seems to be working. Waiting for the tests to pass on CI.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.3%. Comparing base (a10f42a) to head (d9c2074).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files

@@            Coverage Diff            @@
##           develop   #5958     +/-   ##
=========================================
- Coverage     78.3%   78.3%   -0.0%     
=========================================
  Files          817     817             
  Lines        68944   68944             
  Branches      8304    8307      +3     
=========================================
- Hits         53989   53985      -4     
- Misses       14955   14959      +4     

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[pratikmankawde]

The Prepare step is failing on these jobs for Mac OS.
https://github.com/XRPLF/rippled/actions/runs/18938669393/job/54089077884