Sponsored Content
Skip to content

Retire fixCheckThreading - #5957

Merged
bthomee merged 3 commits into
developfrom
a1q123456/retire-fixCheckThreading
Oct 29, 2025
Merged

Retire fixCheckThreading#5957
bthomee merged 3 commits into
developfrom
a1q123456/retire-fixCheckThreading

Conversation

@a1q123456

@a1q123456 a1q123456 commented Oct 29, 2025

Copy link
Copy Markdown
Contributor

High Level Overview of Change

Context of Change

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Performance (increase or change in throughput and/or latency)
  • Tests (you added tests for code that already exists, or your new feature included in this PR)
  • Documentation update
  • Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
  • Release

API Impact

  • Public API: New feature (new methods and/or new fields)
  • Public API: Breaking change (in general, breaking changes should only impact the next api_version)
  • libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
  • Peer protocol change (must be backward compatible or bump the peer protocol version)

Signed-off-by: JCW <a1q123456@users.noreply.github.com>
@a1q123456
a1q123456 requested review from a team, bthomee and pratikmankawde October 29, 2025 13:45
@bthomee bthomee added the Trivial Simple change with minimal effect, or already tested. Only needs one approval. label Oct 29, 2025
Comment thread src/libxrpl/ledger/ApplyStateTable.cpp
@codecov

codecov Bot commented Oct 29, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.3%. Comparing base (efa917d) to head (194f18c).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop   #5957     +/-   ##
=========================================
- Coverage     78.3%   78.3%   -0.0%     
=========================================
  Files          817     817             
  Lines        68968   68965      -3     
  Branches      8302    8304      +2     
=========================================
- Hits         54017   54012      -5     
- Misses       14951   14953      +2     
Files with missing lines Coverage Δ
src/libxrpl/ledger/ApplyStateTable.cpp 93.6% <ø> (+0.2%) ⬆️

... and 2 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread include/xrpl/protocol/detail/features.macro Outdated
Signed-off-by: JCW <a1q123456@users.noreply.github.com>
@a1q123456
a1q123456 force-pushed the a1q123456/retire-fixCheckThreading branch from 04985f6 to 91e85cc Compare October 29, 2025 14:33
@bthomee
bthomee enabled auto-merge (squash) October 29, 2025 16:14
@bthomee
bthomee merged commit 553fb5b into develop Oct 29, 2025
3 checks passed
@bthomee
bthomee deleted the a1q123456/retire-fixCheckThreading branch October 29, 2025 16:36
@mvadari mvadari added this to the 3.2.0 milestone May 20, 2026
beartec-jpg pushed a commit to beartec-jpg/FalconLedger that referenced this pull request Jun 1, 2026
Amendments activated for more than 2 years can be retired. This change retires the fixCheckThreading amendment.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Trivial Simple change with minimal effect, or already tested. Only needs one approval.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants