Sponsored Content
Skip to content

Retire fixSTAmountCanonicalize code - #5956

Merged
bthomee merged 4 commits into
developfrom
pratik/Retire_fixSTAmountCanonicalize_amendment
Oct 29, 2025
Merged

Retire fixSTAmountCanonicalize code#5956
bthomee merged 4 commits into
developfrom
pratik/Retire_fixSTAmountCanonicalize_amendment

Conversation

@pratikmankawde

Copy link
Copy Markdown
Contributor

High Level Overview of Change

This change retires the fixSTAmountCanonicalize amendment.

Context of Change

Amendments activated for more than 2 years can be retired.
https://xrpl.org/resources/known-amendments#fixSTAmountCanonicalize

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Performance (increase or change in throughput and/or latency)
  • Tests (you added tests for code that already exists, or your new feature included in this PR)
  • Documentation update
  • Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
  • Release

Signed-off-by: Pratik Mankawde <pmankawde@ripple.com>
@pratikmankawde
pratikmankawde requested review from a team and a1q123456 October 29, 2025 13:26
Comment thread include/xrpl/protocol/STAmount.h Outdated
@pratikmankawde pratikmankawde added the Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. label Oct 29, 2025
@bthomee
bthomee enabled auto-merge (squash) October 29, 2025 17:41
@bthomee
bthomee disabled auto-merge October 29, 2025 17:41
@bthomee
bthomee enabled auto-merge (squash) October 29, 2025 17:42
@codecov

codecov Bot commented Oct 29, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 33.33333% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.3%. Comparing base (80a3ae6) to head (b510fea).
⚠️ Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
src/libxrpl/protocol/STAmount.cpp 33.3% 6 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop   #5956     +/-   ##
=========================================
- Coverage     78.3%   78.3%   -0.0%     
=========================================
  Files          817     817             
  Lines        68963   68944     -19     
  Branches      8307    8303      -4     
=========================================
- Hits         54007   53990     -17     
+ Misses       14956   14954      -2     
Files with missing lines Coverage Δ
include/xrpl/protocol/STAmount.h 95.3% <ø> (-0.2%) ⬇️
src/xrpld/app/misc/detail/TxQ.cpp 97.6% <ø> (-<0.1%) ⬇️
src/xrpld/app/tx/detail/Transactor.cpp 91.9% <ø> (-<0.1%) ⬇️
src/xrpld/app/tx/detail/apply.cpp 92.8% <ø> (-0.1%) ⬇️
src/libxrpl/protocol/STAmount.cpp 88.9% <33.3%> (+<0.1%) ⬆️

... and 4 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bthomee
bthomee merged commit f8b4f69 into develop Oct 29, 2025
2 of 3 checks passed
@bthomee
bthomee deleted the pratik/Retire_fixSTAmountCanonicalize_amendment branch October 29, 2025 18:17
@mvadari mvadari added this to the 3.2.0 milestone May 20, 2026
beartec-jpg pushed a commit to beartec-jpg/FalconLedger that referenced this pull request Jun 1, 2026
Amendments activated for more than 2 years can be retired. This change retires the fixSTAmountCanonicalize amendment.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants