Sponsored Content
Skip to content

Retired fixRmSmallIncreasedQOffers amendment - #5955

Merged
bthomee merged 3 commits into
developfrom
pratik/Retire_fixRmSmallIncreasedQOffers_amendment
Oct 29, 2025
Merged

Retired fixRmSmallIncreasedQOffers amendment#5955
bthomee merged 3 commits into
developfrom
pratik/Retire_fixRmSmallIncreasedQOffers_amendment

Conversation

@pratikmankawde

Copy link
Copy Markdown
Contributor

High Level Overview of Change

This change retires the fixRmSmallIncreasedQOffers amendment.

Context of Change

Amendments activated for more than 2 years can be retired.
https://xrpl.org/resources/known-amendments#fixRmSmallIncreasedQOffers

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Performance (increase or change in throughput and/or latency)
  • Tests (you added tests for code that already exists, or your new feature included in this PR)
  • Documentation update
  • Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
  • Release

Signed-off-by: Pratik Mankawde <pmankawde@ripple.com>
@pratikmankawde
pratikmankawde marked this pull request as ready for review October 29, 2025 11:23
@pratikmankawde
pratikmankawde requested review from a team and a1q123456 October 29, 2025 11:24
@codecov

codecov Bot commented Oct 29, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.3%. Comparing base (48d38c1) to head (eee8ec5).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop   #5955     +/-   ##
=========================================
- Coverage     78.3%   78.3%   -0.0%     
=========================================
  Files          817     817             
  Lines        68965   68963      -2     
  Branches      8302    8307      +5     
=========================================
- Hits         54020   54006     -14     
- Misses       14945   14957     +12     
Files with missing lines Coverage Δ
src/xrpld/app/tx/detail/OfferStream.cpp 75.2% <ø> (-0.3%) ⬇️

... and 4 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@a1q123456 a1q123456 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

…amendment

Signed-off-by: Pratik Mankawde <pmankawde@ripple.com>
@pratikmankawde pratikmankawde added the Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. label Oct 29, 2025
@bthomee
bthomee enabled auto-merge (squash) October 29, 2025 17:10
@bthomee
bthomee merged commit 80a3ae6 into develop Oct 29, 2025
3 checks passed
@bthomee
bthomee deleted the pratik/Retire_fixRmSmallIncreasedQOffers_amendment branch October 29, 2025 17:34
@mvadari mvadari added this to the 3.2.0 milestone May 20, 2026
beartec-jpg pushed a commit to beartec-jpg/FalconLedger that referenced this pull request Jun 1, 2026
Amendments activated for more than 2 years can be retired. This change retires the fixRmSmallIncreasedQOffers amendment.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants