Sponsored Content
Skip to content

refactor: Remove unnecessary copyright notices already covered by LICENSE.md - #5929

Merged
bthomee merged 29 commits into
developfrom
bthomee/rename_copyright
Nov 4, 2025
Merged

refactor: Remove unnecessary copyright notices already covered by LICENSE.md#5929
bthomee merged 29 commits into
developfrom
bthomee/rename_copyright

Conversation

@bthomee

@bthomee bthomee commented Oct 23, 2025

Copy link
Copy Markdown
Collaborator

High Level Overview of Change

This change removes superfluous copyright notices in source and header files. It also provides a script to allow developers to replicate the changes in their local branch or fork to avoid conflicts.

Context of Change

Per XLS-0095, we are taking steps to rename ripple(d) to xrpl(d).

This change specifically removes all copyright notices referencing Ripple, XRPLF, and certain affiliated contributors upon mutual agreement (many thanks to Vinnie Falco and Howard Hinnant for being flexible), so the notice in the LICENSE.md file applies throughout. Copyright notices referencing external contributions, e.g. from Bitcoin, remain as-is. Duplicate verbiage is also removed.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Performance (increase or change in throughput and/or latency)
  • Tests (you added tests for code that already exists, or your new feature included in this PR)
  • Documentation update
  • Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
  • Release

@bthomee
bthomee requested a review from a team October 23, 2025 15:14
@bthomee

bthomee commented Oct 23, 2025

Copy link
Copy Markdown
Collaborator Author

@dangell7 FYI - note the base branch, which should allow me to merge them all one after another once approval has been given to all of them.

@codecov

codecov Bot commented Oct 23, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.2%. Comparing base (ada8356) to head (e6fba70).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop   #5929     +/-   ##
=========================================
- Coverage     78.2%   78.2%   -0.0%     
=========================================
  Files          816     816             
  Lines        68949   68949             
  Branches      8352    8354      +2     
=========================================
- Hits         53944   53943      -1     
- Misses       15005   15006      +1     
Files with missing lines Coverage Δ
include/xrpl/basics/BasicConfig.h 88.6% <ø> (ø)
include/xrpl/basics/Buffer.h 100.0% <ø> (ø)
include/xrpl/basics/ByteUtilities.h 100.0% <ø> (ø)
include/xrpl/basics/CompressionAlgorithms.h 0.0% <ø> (ø)
include/xrpl/basics/CountedObject.h 100.0% <ø> (ø)
include/xrpl/basics/DecayingSample.h 88.6% <ø> (ø)
include/xrpl/basics/Expected.h 100.0% <ø> (ø)
include/xrpl/basics/IntrusivePointer.h 91.7% <ø> (ø)
include/xrpl/basics/IntrusivePointer.ipp 86.7% <ø> (ø)
include/xrpl/basics/IntrusiveRefCounts.h 92.8% <ø> (ø)
... and 193 more

... and 611 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bthomee bthomee mentioned this pull request Oct 28, 2025
13 tasks
@bthomee
bthomee requested a review from a1q123456 November 1, 2025 20:15

@a1q123456 a1q123456 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Base automatically changed from bthomee/rename_definitions to develop November 4, 2025 07:14
@bthomee
bthomee enabled auto-merge (squash) November 4, 2025 07:35
@bthomee
bthomee merged commit 1d42c4f into develop Nov 4, 2025
3 checks passed
@bthomee
bthomee deleted the bthomee/rename_copyright branch November 4, 2025 08:33
@mvadari mvadari added this to the 3.2.0 milestone May 20, 2026
beartec-jpg pushed a commit to beartec-jpg/FalconLedger that referenced this pull request Jun 1, 2026
…ENSE.md (XRPLF#5929)

Per XLS-0095, we are taking steps to rename ripple(d) to xrpl(d).

This change specifically removes all copyright notices referencing Ripple, XRPLF, and certain affiliated contributors upon mutual agreement, so the notice in the LICENSE.md file applies throughout. Copyright notices referencing external contributions remain as-is. Duplicate verbiage is also removed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants