Retire fix1623 amendment - #5928
Merged
Merged
Conversation
Signed-off-by: Pratik Mankawde <pmankawde@ripple.com>
pratikmankawde
requested review from
a team and
vvysokikh1
and removed request for
a team
October 23, 2025 15:02
pratikmankawde
commented
Oct 23, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #5928 +/- ##
=======================================
Coverage 78.3% 78.3%
=======================================
Files 817 817
Lines 68944 68928 -16
Branches 8324 8301 -23
=======================================
+ Hits 53965 53977 +12
+ Misses 14979 14951 -28
🚀 New features to boost your workflow:
|
vvysokikh1
reviewed
Oct 23, 2025
Signed-off-by: Pratik Mankawde <pmankawde@ripple.com>
Signed-off-by: Pratik Mankawde <pmankawde@ripple.com>
pratikmankawde
requested review from
a1q123456 and
vlntb
and removed request for
vlntb
October 24, 2025 15:08
Signed-off-by: Pratik Mankawde <pmankawde@ripple.com>
vvysokikh1
approved these changes
Oct 28, 2025
Signed-off-by: Pratik Mankawde <pmankawde@ripple.com>
bthomee
enabled auto-merge (squash)
October 30, 2025 15:35
beartec-jpg
pushed a commit
to beartec-jpg/FalconLedger
that referenced
this pull request
Jun 1, 2026
Amendments activated for more than 2 years can be retired. This change retires the fix1623 amendment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
This change retires the
fix1623amendment.Context of Change
Amendments activated for more than 2 years can be retired.
https://xrpl.org/resources/known-amendments#fix1623
Type of Change
.gitignore, formatting, dropping support for older tooling)