Sponsored Content
Skip to content

Retire fix1623 amendment - #5928

Merged
bthomee merged 11 commits into
developfrom
pratik/Retire-fix1623-amendment
Oct 30, 2025
Merged

Retire fix1623 amendment#5928
bthomee merged 11 commits into
developfrom
pratik/Retire-fix1623-amendment

Conversation

@pratikmankawde

Copy link
Copy Markdown
Contributor

High Level Overview of Change

This change retires the fix1623 amendment.

Context of Change

Amendments activated for more than 2 years can be retired.
https://xrpl.org/resources/known-amendments#fix1623

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Performance (increase or change in throughput and/or latency)
  • Tests (you added tests for code that already exists, or your new feature included in this PR)
  • Documentation update
  • Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
  • Release

Signed-off-by: Pratik Mankawde <pmankawde@ripple.com>
@pratikmankawde
pratikmankawde requested review from a team and vvysokikh1 and removed request for a team October 23, 2025 15:02
Comment thread src/xrpld/rpc/detail/DeliveredAmount.cpp
@codecov

codecov Bot commented Oct 23, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.3%. Comparing base (44e027e) to head (208559e).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #5928   +/-   ##
=======================================
  Coverage     78.3%   78.3%           
=======================================
  Files          817     817           
  Lines        68944   68928   -16     
  Branches      8324    8301   -23     
=======================================
+ Hits         53965   53977   +12     
+ Misses       14979   14951   -28     
Files with missing lines Coverage Δ
src/xrpld/app/tx/detail/CashCheck.cpp 92.0% <100.0%> (-<0.1%) ⬇️
src/xrpld/rpc/detail/DeliveredAmount.cpp 84.0% <100.0%> (-2.2%) ⬇️

... and 7 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread src/xrpld/rpc/detail/DeliveredAmount.cpp
Comment thread src/test/app/Check_test.cpp Outdated
Signed-off-by: Pratik Mankawde <pmankawde@ripple.com>
Signed-off-by: Pratik Mankawde <pmankawde@ripple.com>
@pratikmankawde
pratikmankawde requested review from a1q123456 and vlntb and removed request for vlntb October 24, 2025 15:08

@a1q123456 a1q123456 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Pratik Mankawde <pmankawde@ripple.com>
@pratikmankawde pratikmankawde added the Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. label Oct 29, 2025
@bthomee
bthomee enabled auto-merge (squash) October 30, 2025 15:35
@bthomee
bthomee merged commit b0910e3 into develop Oct 30, 2025
3 checks passed
@bthomee
bthomee deleted the pratik/Retire-fix1623-amendment branch October 30, 2025 17:33
@mvadari mvadari added this to the 3.2.0 milestone May 20, 2026
beartec-jpg pushed a commit to beartec-jpg/FalconLedger that referenced this pull request Jun 1, 2026
Amendments activated for more than 2 years can be retired. This change retires the fix1623 amendment.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants