Retired fix1543 amendment - #5926
Merged
Merged
Conversation
bthomee
approved these changes
Oct 23, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #5926 +/- ##
=======================================
Coverage 78.3% 78.3%
=======================================
Files 817 817
Lines 68991 68981 -10
Branches 8326 8324 -2
=======================================
- Hits 54022 54019 -3
+ Misses 14969 14962 -7
... and 3 files with indirect coverage changes 🚀 New features to boost your workflow:
|
pratikmankawde
added
the
Ready to merge
bthomee
removed
the
Ready to merge
Collaborator
|
@pratikmankawde there's a conflict - can you please resolve it first? I'd also like to get a sign-off from @a1q123456 before merging. |
a1q123456
requested changes
Oct 23, 2025
Contributor
Author
Done |
bthomee
approved these changes
Oct 24, 2025
Collaborator
|
@pratikmankawde There are some linking errors due to removing some of the |
bthomee
approved these changes
Oct 24, 2025
Collaborator
|
@pratikmankawde Ready to merge? |
pratikmankawde
added
the
Ready to merge
Contributor
Author
Yeah. |
Amendments activated for more than 2 years can be retired. This change retires the fix1543 amendment.
bthomee
force-pushed
the
pratik/Retire_fix1543_amendment
branch
from
October 28, 2025 14:46
11a99ab to
1ff62d0
Compare
bthomee
enabled auto-merge
October 28, 2025 14:47
beartec-jpg
pushed a commit
to beartec-jpg/FalconLedger
that referenced
this pull request
Jun 1, 2026
Amendments activated for more than 2 years can be retired. This change retires the fix1543 amendment. Co-authored-by: Bart Thomee <11445373+bthomee@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
This change retires the
fix1543amendment.Context of Change
Amendments activated for more than 2 years can be retired.
https://xrpl.org/resources/known-amendments#fix1543
Type of Change
.gitignore, formatting, dropping support for older tooling)