Sponsored Content
Skip to content

Retire amendment fix1515 - #5920

Merged
bthomee merged 1 commit into
developfrom
pratik/Retire_fix1515_amendment
Oct 23, 2025
Merged

Retire amendment fix1515 #5920
bthomee merged 1 commit into
developfrom
pratik/Retire_fix1515_amendment

Conversation

@pratikmankawde

@pratikmankawde pratikmankawde commented Oct 22, 2025

Copy link
Copy Markdown
Contributor

High Level Overview of Change

This change retires the fix1515 amendment.

Context of Change

Amendments activated for more than 2 years can be retired.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Performance (increase or change in throughput and/or latency)
  • Tests (you added tests for code that already exists, or your new feature included in this PR)
  • Documentation update
  • Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
  • Release

@pratikmankawde
pratikmankawde requested a review from a team October 22, 2025 13:28
@pratikmankawde pratikmankawde changed the title removed fix1515 related code and marked it for retiring Retire amendment fix1515 Oct 22, 2025
@pratikmankawde
pratikmankawde requested review from Bronek, a1q123456, bthomee and vvysokikh1 and removed request for a team and Bronek October 22, 2025 13:29
Comment thread src/xrpld/app/paths/detail/BookStep.cpp Outdated
@codecov

codecov Bot commented Oct 22, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.5%. Comparing base (5e33ca5) to head (1772bbd).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop   #5920     +/-   ##
=========================================
- Coverage     79.5%   79.5%   -0.0%     
=========================================
  Files          817     817             
  Lines        72210   72197     -13     
  Branches      8280    8273      -7     
=========================================
- Hits         57398   57380     -18     
- Misses       14812   14817      +5     
Files with missing lines Coverage Δ
src/xrpld/app/paths/detail/BookStep.cpp 95.6% <100.0%> (+0.8%) ⬆️

... and 4 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pratikmankawde
pratikmankawde force-pushed the pratik/Retire_fix1515_amendment branch from 984076f to 0bc852d Compare October 23, 2025 12:18

@a1q123456 a1q123456 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@a1q123456

Copy link
Copy Markdown
Contributor

looks good! feel free to add a ready to merge label

@pratikmankawde pratikmankawde added the Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. label Oct 23, 2025
Amendments activated for more than 2 years can be retired. This change retires the fix1515 amendment.
@bthomee
bthomee force-pushed the pratik/Retire_fix1515_amendment branch from 0bc852d to 1772bbd Compare October 23, 2025 12:35
@bthomee
bthomee added this pull request to the merge queue Oct 23, 2025
Merged via the queue into develop with commit 2bf77cc Oct 23, 2025
3 checks passed
@bthomee
bthomee deleted the pratik/Retire_fix1515_amendment branch October 23, 2025 14:03
@mvadari mvadari added this to the 3.2.0 milestone May 20, 2026
beartec-jpg pushed a commit to beartec-jpg/FalconLedger that referenced this pull request Jun 1, 2026
Amendments activated for more than 2 years can be retired. This change retires the fix1515 amendment.

Co-authored-by: Bart Thomee <11445373+bthomee@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants