Sponsored Content
Skip to content

Moved fix1513 to retire state - #5919

Merged
bthomee merged 1 commit into
developfrom
pratik/Retire_fix1513_amendment
Oct 22, 2025
Merged

Moved fix1513 to retire state#5919
bthomee merged 1 commit into
developfrom
pratik/Retire_fix1513_amendment

Conversation

@pratikmankawde

@pratikmankawde pratikmankawde commented Oct 22, 2025

Copy link
Copy Markdown
Contributor

High Level Overview of Change

This change retires the fix1513 amendment.

Context of Change

Amendments activated for more than 2 years can be retired.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Performance (increase or change in throughput and/or latency)
  • Tests (you added tests for code that already exists, or your new feature included in this PR)
  • Documentation update
  • Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
  • Release

Signed-off-by: Pratik Mankawde <pmankawde@ripple.com>
@pratikmankawde
pratikmankawde requested review from a team, Bronek, bthomee and ximinez and removed request for a team October 22, 2025 13:12

@vvysokikh1 vvysokikh1 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vvysokikh1 vvysokikh1 added Trivial Simple change with minimal effect, or already tested. Only needs one approval. Needs additional review PR requires at least one more code review approval before it can be merged labels Oct 22, 2025
@Bronek Bronek removed the Needs additional review PR requires at least one more code review approval before it can be merged label Oct 22, 2025
@pratikmankawde pratikmankawde added the Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. label Oct 22, 2025
@codecov

codecov Bot commented Oct 22, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.4%. Comparing base (a7792eb) to head (105e1ff).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop   #5919     +/-   ##
=========================================
- Coverage     79.5%   79.4%   -0.0%     
=========================================
  Files          817     817             
  Lines        72209   72208      -1     
  Branches      8283    8294     +11     
=========================================
- Hits         57398   57369     -29     
- Misses       14811   14839     +28     

see 8 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bthomee
bthomee added this pull request to the merge queue Oct 22, 2025
Merged via the queue into develop with commit 7c39c81 Oct 22, 2025
3 checks passed
@bthomee
bthomee deleted the pratik/Retire_fix1513_amendment branch October 22, 2025 15:17
@mvadari mvadari added this to the 3.2.0 milestone May 20, 2026
beartec-jpg pushed a commit to beartec-jpg/FalconLedger that referenced this pull request Jun 1, 2026
Signed-off-by: Pratik Mankawde <pmankawde@ripple.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. Trivial Simple change with minimal effect, or already tested. Only needs one approval.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants