Sponsored Content
Skip to content

Refactor: replace fee().accountReserve(0) with fee().reserve - #5843

Merged
bthomee merged 1 commit into
XRPLF:developfrom
tequdev:refactor-accountReserve-increment
Oct 15, 2025
Merged

Refactor: replace fee().accountReserve(0) with fee().reserve#5843
bthomee merged 1 commit into
XRPLF:developfrom
tequdev:refactor-accountReserve-increment

Conversation

@tequdev

@tequdev tequdev commented Oct 3, 2025

Copy link
Copy Markdown
Member

High Level Overview of Change

Fixed fee().accountReserve(0) to use fee().reserve for getting the current network reserve amount that not for acquiring account’s reserve.

Type of Change

  • Refactor (non-breaking change that only restructures code)

@tequdev
tequdev requested a review from a team October 3, 2025 13:28
@codecov

codecov Bot commented Oct 3, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.5%. Comparing base (3d44758) to head (aaeae45).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop   #5843     +/-   ##
=========================================
- Coverage     79.5%   79.5%   -0.0%     
=========================================
  Files          816     816             
  Lines        72183   72179      -4     
  Branches      8273    8271      -2     
=========================================
- Hits         57369   57364      -5     
- Misses       14814   14815      +1     
Files with missing lines Coverage Δ
src/xrpld/app/misc/FeeVoteImpl.cpp 95.9% <100.0%> (ø)
src/xrpld/app/misc/NetworkOPs.cpp 71.5% <100.0%> (-0.1%) ⬇️
src/xrpld/app/misc/detail/TxQ.cpp 97.7% <100.0%> (ø)
src/xrpld/app/paths/PathRequest.cpp 73.3% <100.0%> (-0.1%) ⬇️
src/xrpld/app/paths/Pathfinder.cpp 89.2% <100.0%> (ø)
src/xrpld/app/tx/detail/Payment.cpp 93.8% <100.0%> (ø)
src/xrpld/app/tx/detail/XChainBridge.cpp 91.7% <100.0%> (ø)

... and 3 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Tapanito
Tapanito requested review from mvadari and vvysokikh1 October 3, 2025 15:06
@bthomee bthomee added this to the 3.1.0 milestone Oct 3, 2025
@Tapanito Tapanito added the Triaged Issue/PR has been triaged for viability, liveliness, etc. label Oct 3, 2025
@mvadari mvadari added Trivial Simple change with minimal effect, or already tested. Only needs one approval. Blocked labels Oct 3, 2025
@mvadari

mvadari commented Oct 3, 2025

Copy link
Copy Markdown
Contributor

Blocked for now on the 3.0 release, will be merged after that

@mvadari mvadari removed the Blocked label Oct 14, 2025
@mvadari

mvadari commented Oct 14, 2025

Copy link
Copy Markdown
Contributor

@tequdev is this PR ready to merge?

@tequdev

tequdev commented Oct 15, 2025

Copy link
Copy Markdown
Member Author

@tequdev is this PR ready to merge?

yes👍

@mvadari mvadari added the Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. label Oct 15, 2025
This PR changes fee().accountReserve(0) to fee().reserve, as the current network reserve amount should be used instead of the account reserve.
@bthomee
bthomee force-pushed the refactor-accountReserve-increment branch from c310c12 to aaeae45 Compare October 15, 2025 19:44
@bthomee
bthomee enabled auto-merge October 15, 2025 19:44
@bthomee
bthomee added this pull request to the merge queue Oct 15, 2025
Merged via the queue into XRPLF:develop with commit 519d1db Oct 15, 2025
3 checks passed
@mvadari mvadari modified the milestones: 3.1.0, 3.2.0 May 20, 2026
beartec-jpg pushed a commit to beartec-jpg/FalconLedger that referenced this pull request Jun 1, 2026
)

This PR changes fee().accountReserve(0) to fee().reserve, as the current network reserve amount should be used instead of the account reserve.

Co-authored-by: Bart Thomee <11445373+bthomee@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. Triaged Issue/PR has been triaged for viability, liveliness, etc. Trivial Simple change with minimal effect, or already tested. Only needs one approval.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants