Refactor: replace fee().accountReserve(0) with fee().reserve - #5843
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #5843 +/- ##
=========================================
- Coverage 79.5% 79.5% -0.0%
=========================================
Files 816 816
Lines 72183 72179 -4
Branches 8273 8271 -2
=========================================
- Hits 57369 57364 -5
- Misses 14814 14815 +1
🚀 New features to boost your workflow:
|
mvadari
approved these changes
Oct 3, 2025
Contributor
|
Blocked for now on the 3.0 release, will be merged after that |
vvysokikh1
approved these changes
Oct 6, 2025
Contributor
|
@tequdev is this PR ready to merge? |
Member
Author
yes👍 |
This PR changes fee().accountReserve(0) to fee().reserve, as the current network reserve amount should be used instead of the account reserve.
bthomee
force-pushed
the
refactor-accountReserve-increment
branch
from
October 15, 2025 19:44
c310c12 to
aaeae45
Compare
bthomee
enabled auto-merge
October 15, 2025 19:44
beartec-jpg
pushed a commit
to beartec-jpg/FalconLedger
that referenced
this pull request
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Fixed
fee().accountReserve(0)to usefee().reservefor getting the current network reserve amount that not for acquiring account’s reserve.Type of Change